Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement cancel command properly #536

Merged
merged 4 commits into from
Aug 6, 2021
Merged

Conversation

rntz
Copy link
Collaborator

@rntz rntz commented Aug 2, 2021

No description provided.

code/cancel.py Outdated
cancel_phrase = "cancel cancel".split()

def pre_phrase(d):
logging.info(d)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Urk, I should remove this line.

@rntz rntz marked this pull request as draft August 3, 2021 03:06
Copy link
Collaborator

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

misc/cancel.talon Outdated Show resolved Hide resolved
@rntz rntz marked this pull request as ready for review August 3, 2021 13:54
@rntz rntz merged commit e88cfd4 into talonhub:master Aug 6, 2021
@rntz rntz deleted the cancel-cancel branch August 6, 2021 17:41
daanvdh pushed a commit to daanvdh/knausj_talon that referenced this pull request Sep 2, 2021
* master: (55 commits)
  Added command mode to all language headers to prevent them being active in sleep mode (talonhub#569)
  Change command client keyboard shortcut (talonhub#572)
  Make slap command work with Slack (talonhub#535)
  Add Pound Sterling (£) Sign (talonhub#523)
  `quote that` and `inside quotes` changes (talonhub#538)
  Knausj generic terminal establishment (talonhub#514)
  Add right-drag command to Talon (talonhub#498)
  Add a small delay to tab close on Chrome (talonhub#553)
  fix tab jumping for firefox on linux (talonhub#558)
  implement cancel command properly (talonhub#536)
  Add a command to copy the url of the current page (talonhub#534)
  Add fetch all to convenience mappings
  Update .gitignore
  Ignore settings directory
  Delete cancel.talon
  Fix Mac Terminal Copy-paste (talonhub#525)
  add phones word/word left/word right commands (talonhub#531)
  Update switcher.py (talonhub#529)
  jetbrains filename() quick fix
  Update switcher.py
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants