-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quote that
and inside quotes
changes
#538
quote that
and inside quotes
changes
#538
Conversation
* Makes the command for single quotes and double courts consistent with keys.py * Adds a string option when making single quotes in order to be consistent with the 'string' command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, except for a niggle about "string that" already being a command.
text/symbols.talon
Outdated
@@ -62,7 +65,10 @@ angle that: | |||
percent that: | |||
text = edit.selected_text() | |||
user.paste("%{text}%") | |||
quote that: | |||
(quote | string) that: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
string that
is already a command, since string
is a formatter and <user.formatters> that
is a command. so probably just make this "quote that".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, amended
* master: (55 commits) Added command mode to all language headers to prevent them being active in sleep mode (talonhub#569) Change command client keyboard shortcut (talonhub#572) Make slap command work with Slack (talonhub#535) Add Pound Sterling (£) Sign (talonhub#523) `quote that` and `inside quotes` changes (talonhub#538) Knausj generic terminal establishment (talonhub#514) Add right-drag command to Talon (talonhub#498) Add a small delay to tab close on Chrome (talonhub#553) fix tab jumping for firefox on linux (talonhub#558) implement cancel command properly (talonhub#536) Add a command to copy the url of the current page (talonhub#534) Add fetch all to convenience mappings Update .gitignore Ignore settings directory Delete cancel.talon Fix Mac Terminal Copy-paste (talonhub#525) add phones word/word left/word right commands (talonhub#531) Update switcher.py (talonhub#529) jetbrains filename() quick fix Update switcher.py ...
Because this changes the behavior of the existing
quote that
andinside quotes
commands, I'd love to get a few reviews and some discussion.