Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quote that and inside quotes changes #538

Merged
merged 4 commits into from
Aug 21, 2021

Conversation

xavier630
Copy link
Contributor

  1. Adds a command to insert single quotes around text
  2. Makes the command for single quotes and double quotes consistent with keys.py
  3. Adds a 'string' option when making single quotes in order to be consistent with the 'string' command

Because this changes the behavior of the existing quote that and inside quotes commands, I'd love to get a few reviews and some discussion.

* Makes the command for single quotes and double courts consistent with keys.py
* Adds a string option when making single quotes in order to be consistent with the 'string' command
Copy link
Collaborator

@rntz rntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, except for a niggle about "string that" already being a command.

@@ -62,7 +65,10 @@ angle that:
percent that:
text = edit.selected_text()
user.paste("%{text}%")
quote that:
(quote | string) that:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string that is already a command, since string is a formatter and <user.formatters> that is a command. so probably just make this "quote that".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, amended

@fidgetingbits fidgetingbits merged commit b6e4a80 into talonhub:master Aug 21, 2021
daanvdh pushed a commit to daanvdh/knausj_talon that referenced this pull request Sep 2, 2021
* master: (55 commits)
  Added command mode to all language headers to prevent them being active in sleep mode (talonhub#569)
  Change command client keyboard shortcut (talonhub#572)
  Make slap command work with Slack (talonhub#535)
  Add Pound Sterling (£) Sign (talonhub#523)
  `quote that` and `inside quotes` changes (talonhub#538)
  Knausj generic terminal establishment (talonhub#514)
  Add right-drag command to Talon (talonhub#498)
  Add a small delay to tab close on Chrome (talonhub#553)
  fix tab jumping for firefox on linux (talonhub#558)
  implement cancel command properly (talonhub#536)
  Add a command to copy the url of the current page (talonhub#534)
  Add fetch all to convenience mappings
  Update .gitignore
  Ignore settings directory
  Delete cancel.talon
  Fix Mac Terminal Copy-paste (talonhub#525)
  add phones word/word left/word right commands (talonhub#531)
  Update switcher.py (talonhub#529)
  jetbrains filename() quick fix
  Update switcher.py
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants