Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed editing track name clears the old entry on double-click #980

Merged
merged 4 commits into from
Oct 11, 2022

Conversation

hsingchien
Copy link
Contributor

Description

PR 1/3 for #977
In the current version, double clicking track name in instance table will clear the old name. This can be easily fixed by asking GenericTableModel to display also under EditRole in dataviews.py>GenericTableModel>data.

Types of changes

  • Bugfix
  • New feature
  • Refactor / Code style update (no logical changes)
  • Build / CI changes
  • Documentation Update
  • Other (explain)

Does this address any currently open issues?

[list open issues here]

Outside contributors checklist

  • Review the guidelines for contributing to this repository
  • [] Read and sign the CLA and add yourself to the authors list
  • Make sure you are making a pull request against the develop branch (not main). Also you should start your branch off develop
  • Add tests that prove your fix is effective or that your feature works
  • Add necessary documentation (if appropriate)

Thank you for contributing to SLEAP!

❤️

@roomrys roomrys self-assigned this Oct 6, 2022
@roomrys roomrys marked this pull request as ready for review October 6, 2022 19:39
@roomrys
Copy link
Collaborator

roomrys commented Oct 6, 2022

I made an update to the ubuntu image used by Github actions in order for the tests to run (ubuntu-18.04 is depreciated). Otherwise, the PR looks good to me - we'll see how the tests fair (if they fail, it's likely due to the image update).

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #980 (97cd3c7) into develop (c19cf5a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #980   +/-   ##
========================================
  Coverage    66.75%   66.75%           
========================================
  Files          127      127           
  Lines        21469    21469           
========================================
  Hits         14332    14332           
  Misses        7137     7137           
Impacted Files Coverage Δ
sleap/gui/dataviews.py 81.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hsingchien
Copy link
Contributor Author

I made an update to the ubuntu imaged used by Github actions in order for the tests to run (ubuntu-18.04 is depreciated). Otherwise, the PR looks good to me - we'll see how the tests fair (if they fail, it's likely due to the image update).

Thank you @roomrys for updating the image!
The codecov test failed. Any suggestions?

@roomrys
Copy link
Collaborator

roomrys commented Oct 11, 2022

Hi @hsingchien,

#985 should fix the tests issue. After the checks pass, we will be ready to merge into develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants