Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI Table: Do not set item value if same as current value #1022

Merged
merged 4 commits into from
Nov 7, 2022

Conversation

linwang9926
Copy link
Contributor

@linwang9926 linwang9926 commented Nov 1, 2022

Description

Fix the issue #1013 . Users can keep their node name while double click the item name.

Types of changes

  • Bugfix
  • New feature
  • Refactor / Code style update (no logical changes)
  • Build / CI changes
  • Documentation Update
  • Other (explain)

Does this address any currently open issues?

Outside contributors checklist

  • Review the guidelines for contributing to this repository
  • Read and sign the CLA and add yourself to the authors list
  • Make sure you are making a pull request against the develop branch (not main). Also you should start your branch off develop
  • Add tests that prove your fix is effective or that your feature works
  • Add necessary documentation (if appropriate)

Thank you for contributing to SLEAP!

❤️

@roomrys roomrys changed the title Fix issue #1013, keep the node name while double click Do not set item value if same as current value Nov 1, 2022
Copy link
Collaborator

@roomrys roomrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit pick: change item_name to item_value

sleap/gui/dataviews.py Outdated Show resolved Hide resolved
sleap/gui/dataviews.py Outdated Show resolved Hide resolved
sleap/gui/dataviews.py Outdated Show resolved Hide resolved
Change "item_name" to "item_value"

Co-authored-by: Liezl Maree <38435167+roomrys@users.noreply.github.com>
@roomrys roomrys changed the title Do not set item value if same as current value GUI Table: Do not set item value if same as current value Nov 1, 2022
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #1022 (5f997da) into develop (7ca3918) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #1022      +/-   ##
===========================================
- Coverage    66.77%   66.75%   -0.02%     
===========================================
  Files          127      127              
  Lines        21508    21514       +6     
===========================================
  Hits         14362    14362              
- Misses        7146     7152       +6     
Impacted Files Coverage Δ
sleap/gui/dataviews.py 79.41% <0.00%> (-1.59%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@linwang9926 linwang9926 marked this pull request as ready for review November 1, 2022 22:17
@roomrys roomrys merged commit f22d080 into talmolab:develop Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants