Run nyc with correct packager manager command #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
This seems to have worked splendidly for us, running it with |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #364 +/- ##
=======================================
Coverage 76.66% 76.66%
=======================================
Files 11 11
Lines 180 180
Branches 40 40
=======================================
Hits 138 138
Misses 42 42 ☔ View full report in Codecov by Sentry. |
|
Thank you so much for testing it out @Marvellanius !! I'll merge and release |
This was referenced Oct 30, 2023
Merged
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #266
Originally created by @ferdinandhummel-gph in #271.
This PR introduces a fix to the coverage functionality of the test-runner, where the nyc command is run using the correct package manager exec command. This fixes compatibility with package managers other than
npm, such asyarnorpnpm.Only reason I'm creating this PR is to allow for the canary release workflow to be done, which wasn't possible in the fork from the previous PR. Thank you @ferdinandhummel-gph !
For the ones interested, please try the canary and provide feedback:
📦 Published PR as canary version:
0.13.1--canary.364.06c986a.0✨ Test out this PR locally via:
npm install @storybook/test-runner@0.13.1--canary.364.06c986a.0 # or yarn add @storybook/test-runner@0.13.1--canary.364.06c986a.0Version
Published prerelease version:
v0.13.1-next.2Changelog
🐛 Bug Fix
engines.nodeto>=12.0.0#351 (@legobeat)🏠 Internal
yarn.lock#347 (@legobeat)📝 Documentation
Authors: 4