Run nyc with correct packager manager command #271
Conversation
bin/test-storybook.js
Outdated
| } | ||
|
|
||
| // Copied from github.com/nrwl/nx/blob/1975181c200eb288221c8beb94e268fe9659cc26/packages/nx/src/utils/package-manager.ts#L48-106 | ||
| function getPackageManagerCommand(packageManager = detectPackageManager()) { |
There was a problem hiding this comment.
What if people are running this in a monorepo that only has a package.json at the root level? If they're using yarn workspaces, for instance, this function will endup saying that it's an npm project, right?
There was a problem hiding this comment.
All scripts are usually run with cwd set to same directory as the package.json (eg. npm run ... automatically takes care of that even if you run it from a directory within your porject).
We are using a nx mono repository with one single package.json in the root of the repo, tested it and works fine
|
Hey @yannbf |
Hey Gil! This contribution does not account for certain monorepo settings because it doesn't find the files up, e.g. executing a script in a directory that has a package.json but not a .yarnrc file, which is higher in the tree. I'll try to improve this next week! |
|
Maybe you can get some inspiration from this repo: https://github.com/egoist/detect-package-manager |
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
Thanks for the suggestion @watcher46! I continued the work on this PR and I think it's done. However I'm creating another PR to allow for the canary release workflow to be done, which wasn't possible in the fork from this PR. Please follow that PR instead: #364 For the ones interested, please try the canary and provide feedback on the other PR: Once I have proper feedback that this fixed your issues, I will cut a release. Thank you! |
fixes #266
runs nyc command using the correct package manager exec command to fix compatibility with pnpm
📦 Published PR as canary version:
0.13.1--canary.271.8c62e28.0✨ Test out this PR locally via:
npm install @storybook/test-runner@0.13.1--canary.271.8c62e28.0 # or yarn add @storybook/test-runner@0.13.1--canary.271.8c62e28.0