Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set engines.node to >=12.0.0 #351

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 3, 2023

This indicates currently working Node.js versions.

Below error on Node.js v10:

$ yarn
internal/modules/cjs/loader.js:638
    throw err;
    ^

Error: Cannot find module 'worker_threads'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at /app/.yarn/releases/yarn-3.6.3.cjs:423:3061
    at Object.<anonymous> (/app/.yarn/releases/yarn-3.6.3.cjs:744:8770)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)

@legobeat legobeat changed the title chore: set engines.node to ^12.0.0. chore: set engines.node to >=12.0.0. Sep 3, 2023
@legobeat legobeat changed the title chore: set engines.node to >=12.0.0. chore: set engines.node to >=12.0.0 Sep 3, 2023
@legobeat legobeat changed the title chore: set engines.node to >=12.0.0 chore: set engines.node to >=12.0.0 Sep 3, 2023
@legobeat legobeat marked this pull request as ready for review September 3, 2023 03:35
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kasperpeulen kasperpeulen added patch Increment the patch version when merged bug Something isn't working labels Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9e1136e) 76.66% compared to head (aff54d6) 76.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #351   +/-   ##
=======================================
  Coverage   76.66%   76.66%           
=======================================
  Files          11       11           
  Lines         180      180           
  Branches       40       40           
=======================================
  Hits          138      138           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yannbf
Copy link
Member

yannbf commented Sep 6, 2023

Hey @legobeat thank you so much for all of your contributions <3

Copy link

github-actions bot commented Nov 8, 2023

🚀 PR was released in v0.14.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants