Update neorv32_sdi.vhd - Minor typo correction #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX FIFO misses the value setting for FULL_RESET generic completly. I suppose then it falls back to the default value, since that one is false too in the neorv32_fifo.vhd this commit isn't leading to any different behavior in RTL, but should be added just for consisentcy issues Signed-off-by: ucycg <101277242+ucycg@users.noreply.github.com>
|
Sry if this isn't the proper way to merge stuff, but I just wanted to hint the pony inconsistency I just discovered in a quick way https://github.com/stnolting/neorv32/blob/main/rtl/core/neorv32_sdi.vhd#L214 Btw how can I make these nice links of graphical representation of code from a file like you did in #878 inside a comment instead of just linking it? |
stnolting
added
HW
|
Looks great!
|
stnolting
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RX FIFO misses the value setting for FULL_RESET generic completly. I suppose then it falls back to the default value, since that one is false too in the neorv32_fifo.vhd this commit isn't leading to any different behavior in RTL, but should be added just for consisentcy issues