Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mv riscv-arch-test sw/sig-arch-test #117

Merged
merged 6 commits into from
Jul 12, 2021
Merged

Conversation

umarcor
Copy link
Collaborator

@umarcor umarcor commented Jul 11, 2021

As discussed in #109, in this PR submodule riscv-arch-test is moved to sw/sig-arch-test, and the run_riscv_arch_test.sh script is moved to subdir sim.

READMEs and gitignore files are updated accordingly.

@stnolting
Copy link
Owner

Looks good!
But why "SIG-arch-test"? I don't get it 😄

@umarcor
Copy link
Collaborator Author

umarcor commented Jul 12, 2021

But why "SIG-arch-test"? I don't get it 😄

Just for avoiding users/developers being mislead because of having the same name repeated sw/riscv-arch-test/riscv-arch-test. Previously, it was riscv-arch-test/work/riscv-arch-test so the work in the middle made it explicit not to be a mistake. Now work is created in sim/work.

SIG comes from the title of https://github.com/riscv/riscv-arch-test/blob/master/README.md, which is also the name of the mailing list: https://lists.riscv.org/g/sig-arch-test. Honestly, I did not find what does SIG stand for...

@stnolting
Copy link
Owner

Just for avoiding users/developers being mislead because of having the same name repeated sw/riscv-arch-test/riscv-arch-test. Previously, it was riscv-arch-test/work/riscv-arch-test so the work in the middle made it explicit not to be a mistake. Now work is created in sim/work.

Right. We could also keep riscv-arch-test, have no additional riscv-arch-test folder and directly clone that repository in that, right?

SIG comes from the title of https://github.com/riscv/riscv-arch-test/blob/master/README.md, which is also the name of the mailing list: https://lists.riscv.org/g/sig-arch-test. Honestly, I did not find what does SIG stand for...

Now I get it 😆
I think SIG = special interest group

@umarcor
Copy link
Collaborator Author

umarcor commented Jul 12, 2021

Right. We could also keep riscv-arch-test, have no additional riscv-arch-test folder and directly clone that repository in that, right?

Not really... I thought about it, but there is port-neorv32, apart from the submoduled directory. Moreover, in branch sw-parallel of my fork (which is a follow-up of this PR), there is also common.mk (although we might move that to port-neorv32. Anyway, the point is that we need two directories, at least, the submodule and the port. I'm good with having both of them in sw, but I was not sure about doing it.

Now I get it 😆
I think SIG = special interest group

Thanks! That makes sense ❤️

EDIT

Maybe sw/riscv-arch-test and sw/riscv-arch-test-neorv32?

@stnolting
Copy link
Owner

Anyway, the point is that we need two directories, at least, the submodule and the port. I'm good with having both of them in sw, but I was not sure about doing it.

Convinced! 👍

Maybe sw/riscv-arch-test and sw/riscv-arch-test-neorv32?

Let's keep it in one directory. I would put everything in sw/riscv-compatibility/ but the term "compatibility" is not really welcomed by RISC-V 😅 So how about just sw/arch-test/, sw/isa-test or sw/riscv-test/? This way there is some "connection" to sw/processor_check (which should be processor_test when I think about it again).

@umarcor
Copy link
Collaborator Author

umarcor commented Jul 12, 2021

Let's keep it in one directory. I would put everything in sw/riscv-compatibility/ but the term "compatibility" is not really welcomed by RISC-V 😅 So how about just sw/arch-test/, sw/isa-test or sw/riscv-test/? This way there is some "connection" to sw/processor_check (which should be processor_test when I think about it again).

I now moved it to sw/isa-test . I like it. Short (easy to type) and descriptive 😄

With regard to processor_check, actually I believe it should be moved out of sw/example (and maybe demo_freeRTOS too). However, let's go one step at a time 😉. If you are good with this, let's have it merged and I will rebase #118 (which is where we are rewroking the examples).

@umarcor umarcor marked this pull request as draft July 12, 2021 13:50
@umarcor
Copy link
Collaborator Author

umarcor commented Jul 12, 2021

CI running: https://github.com/umarcor/neorv32/actions/runs/1023051910

@stnolting stnolting marked this pull request as ready for review July 12, 2021 14:00
@stnolting
Copy link
Owner

Let me just update the documentation here (I will also fill the spare parts of sw/README.md - otherwise I will for sure forget about these).

@stnolting
Copy link
Owner

Let me just update the documentation here (I will also fill the spare parts of sw/README.md - otherwise I will for sure forget about these).

Ok, I'll have to do that later 🙈

@stnolting stnolting merged commit 5366229 into stnolting:master Jul 12, 2021
@umarcor umarcor deleted the sw-move branch July 12, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants