Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split ISA test suites in multiple jobs and rework makefiles #124

Merged
merged 5 commits into from
Jul 13, 2021

Conversation

umarcor
Copy link
Collaborator

@umarcor umarcor commented Jul 12, 2021

This is a follow-up of #117 and it's related to #119.

First, the CI workflow riscv-arch-test is updated for running four parallel jobs, each executing one test suite (I, C, M or privilege).

Then, several optimisations are applied to the makefiles:

  • common.mk is added so that most of the entrypoints in the suites require 1-3 lines only.
  • Instead of using sed for overwritting the parameters in the testbench source, top-level generics are used.
  • Instead of analising (ghdl -i) for each test, the simulation script is split into ghdl.setup.sh and ghdl.run.sh.

@stnolting
Copy link
Owner

I like this! It's very elegant! 👍

(sorry for the delay - there was quite a lot to dig through 😄)

@stnolting stnolting merged commit e6da52c into stnolting:master Jul 13, 2021
@umarcor
Copy link
Collaborator Author

umarcor commented Jul 13, 2021

(sorry for the delay - there was quite a lot to dig through 😄)

Hey! Absolutely no worries or rush at all! Not for this PR, not for any other. We have all our lives ahead!
I recommend having a look at Sections 6 and 7 of https://opensource.guide/best-practices/

@umarcor umarcor deleted the sw-parallel branch July 13, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants