Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv-arch-test script cleanup #109

Merged
merged 2 commits into from
Jul 9, 2021

Conversation

umarcor
Copy link
Collaborator

@umarcor umarcor commented Jul 8, 2021

This is some cleanup of the riscv-arch-test/run_riscv_arch_test.sh script. It should be functionally equivalent, but easier to read/maintain.

Moreover, it seems that subdir riscv-arch-test is used just for simulation with GHDL. @stnolting, what do you think about moving it into sim/riscv-arch-test? That would keep the root of the project cleaner, while making it explicit that the riscv-arch-test are used for testing/verification. In the future, we might enhance run_riscv_arch_test.sh for using some VUnit features, or have it removed and handle these tests in the existing sim/run.py script.

@stnolting
Copy link
Owner

This is some cleanup of the riscv-arch-test/run_riscv_arch_test.sh script. It should be functionally equivalent, but easier to read/maintain.

Look good! 👍
According to https://github.com/umarcor/neorv32/actions/workflows/riscv-arch-test.yml the modified script works correctly, right?

Moreover, it seems that subdir riscv-arch-test is used just for simulation with GHDL. @stnolting, what do you think about moving it into sim/riscv-arch-test? That would keep the root of the project cleaner, while making it explicit that the riscv-arch-test are used for testing/verification.

I always wanted to put riscv-arch-test into the sw folder - because it is software 😄 My plan was to support on-board execution of the tests, too, but I have not further worked on that...

However, I really like the idea of using VUnit to accelerate simulation of the tests (#35). So, yeah, I'm fine with moving the tests to the simulation folder. 👍

@umarcor
Copy link
Collaborator Author

umarcor commented Jul 9, 2021

I always wanted to put riscv-arch-test into the sw folder - because it is software 😄 My plan was to support on-board execution of the tests, too, but I have not further worked on that...

However, I really like the idea of using VUnit to accelerate simulation of the tests (#35). So, yeah, I'm fine with moving the tests to the simulation folder. 👍

That makes sense... How about merging this as-is for now? Then we might move the software to subdir sw and the test script itself to subdir sim, which would be the most coherent with other test setups.

@umarcor
Copy link
Collaborator Author

umarcor commented Jul 9, 2021

According to https://github.com/umarcor/neorv32/actions/workflows/riscv-arch-test.yml the modified script works correctly, right?

Yeah. I run it for testing that the colours were properly shown: https://github.com/umarcor/neorv32/runs/3024526753?check_suite_focus=true#step:5:95. That's the reason for using printf instead of echo.

@stnolting stnolting merged commit 4f55c58 into stnolting:master Jul 9, 2021
@umarcor umarcor deleted the arch-test-cleanup branch July 9, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants