Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some cleanup of the
riscv-arch-test/run_riscv_arch_test.sh
script. It should be functionally equivalent, but easier to read/maintain.Moreover, it seems that subdir
riscv-arch-test
is used just for simulation with GHDL. @stnolting, what do you think about moving it intosim/riscv-arch-test
? That would keep the root of the project cleaner, while making it explicit that the riscv-arch-test are used for testing/verification. In the future, we might enhancerun_riscv_arch_test.sh
for using some VUnit features, or have it removed and handle these tests in the existingsim/run.py
script.