Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert 159 main #160

Merged
merged 5 commits into from
Apr 4, 2024
Merged

Revert 159 main #160

merged 5 commits into from
Apr 4, 2024

Conversation

lovelesh-mis
Copy link
Contributor

  • Reverted changes to synthesis.mk
  • Added iCEBreaker on-board LEDs to the top module

@stnolting stnolting requested a review from umarcor March 19, 2024 16:38
@stnolting stnolting mentioned this pull request Mar 19, 2024
Merged
@stnolting
Copy link
Owner

Thanks for the update!

umarcor
umarcor reviewed Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@umarcor umarcor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that some other changes were unwantedly added to this PR. Particularly an empty binary file is added. Please, remove at least that one.

@stnolting stnolting marked this pull request as draft March 19, 2024 19:56
@lovelesh-mis lovelesh-mis marked this pull request as ready for review March 25, 2024 13:33
@stnolting
Copy link
Owner

I think the changes in the Radiant version are fine.

So in my opinion it's ready to be merged 👍

@stnolting
Copy link
Owner

@lovelesh-mis this is ready, right? 😉

@lovelesh-mis
Copy link
Contributor Author

lovelesh-mis commented Apr 4, 2024 via email

@stnolting stnolting merged commit 1838100 into stnolting:main Apr 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umarcor umarcor umarcor left review comments

@stnolting stnolting stnolting approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lovelesh-mis @stnolting @umarcor