Resolved ghdl synthesis error

[lovelesh-mis]

• Resolved GHDL synthesis error
• Added on-board LEDs for iCEBreaker_UP5KDemo.vhd

[stnolting]

Thanks for fixing/updating!

[umarcor]

Hardcoding this is not correct. -m ghdl depends on how was ghdl-yosys-plugin built/installed. If it was built statically into Yosys, that argument is not required and using it will produce an error. That is the case on MSYS2. Conversely, if the plugin was built as a shared library,-m ghdl can have various meanings. ghdl means that the library is located in a specific location known by yosys and with an specific extension. Other users might have the file located elsewhere or named elsehow. Therefore, if someone needs to pass -m ghdl, that should be done through the variables.

Precisely, there is support for this feature in this repo already. See:

neorv32-setups/osflow/common.mk

Lines 19 to 21 in bd8880b

	ifdef GHDL_PLUGIN_MODULE
	YOSYSFLAGS += -m $(GHDL_PLUGIN_MODULE)
	endif

So, you just need to use GHDL_PLUGIN_MODULE=ghdl, as done in the dockerfile (see

neorv32-setups/.github/impl.dockerfile

Line 11 in bd8880b

ENV GHDL_PLUGIN_MODULE=ghdl

), because the CI in this repo uses that feature.

Please, revert this change.

[stnolting]

Good point. I did not realize that... 🙈

[stnolting]

-> #160