[dash]: Don't attempt to bind empty ACL groups #2613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
theasianpianist
force-pushed
the
dash-bind-empty-acl-group
branch
from
934d33b
to
9d38430
Compare
Pterosaur
approved these changes
Jan 11, 2023
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
prsunny
approved these changes
Jan 19, 2023
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
theasianpianist
force-pushed
the
dash-bind-empty-acl-group
branch
from
56369e9
to
5d6e0c6
Compare
theasianpianist
added a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Jul 21, 2023
* [dash]: Don't attempt to bind empty ACL groups Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
theasianpianist
added a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Jul 25, 2023
* [dash]: Don't attempt to bind empty ACL groups Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
theasianpianist
added a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Jul 27, 2023
* [dash]: Don't attempt to bind empty ACL groups Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lawrence Lee lawlee@microsoft.com
What I did
Before binding an ACL group to an ENI, make sure that the ACL group contains at least 1 rule. If the group is empty, retry the bind operation later.
Test improvements:
wait_for*methods inDVSDatabaseto verify database contents instead of naively sleepingWhy I did it
Attempting to bind an empty ACL group to an ENI results in a SAI failure with no opportunity to retry.
How I verified it
test_dash_acl.pyDetails if related