[dash]: Don't attempt to bind empty ACL groups (sonic-net#2613)

* [dash]: Don't attempt to bind empty ACL groups Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
theasianpianist · Jul 25, 2023 · 40a23b9 · 40a23b9
1 parent 2eb306a
commit 40a23b9
Show file tree

Hide file tree

Showing 2 changed files with 213 additions and 112 deletions.
diff --git a/orchagent/dash/dashaclorch.cpp b/orchagent/dash/dashaclorch.cpp
@@ -761,6 +761,13 @@ task_process_status DashAclOrch::bindAclToEni(DashAclTable &acl_table, const str
             return task_need_retry;
         }
 
+        if (acl_group->m_rule_count <= 0)
+        {
+            SWSS_LOG_INFO("acl group %s contains 0 rules, waiting for rule creation", acl.m_acl_group_id->c_str());
+            acl.m_acl_group_id.reset();
+            return task_need_retry;
+        }
+
         attr.id = getSaiStage(direction, *(acl_group->m_ip_version), stage);
         attr.value.oid = acl_group->m_dash_acl_group_id;
     }