Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dash]: Don't attempt to bind empty ACL groups #2613

Merged
merged 3 commits into from
Jan 20, 2023
Merged

[dash]: Don't attempt to bind empty ACL groups #2613

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d38430
[dash]: Don't attempt to bind empty ACL groups
theasianpianist Jan 11, 2023
75f9251
reset ACL group ID before retrying binding
theasianpianist Jan 19, 2023
5d6e0c6
Improve DASH ACL tests
theasianpianist Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions orchagent/dash/dashaclorch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,6 +761,13 @@ task_process_status DashAclOrch::bindAclToEni(DashAclTable &acl_table, const str
return task_need_retry;
}

if (acl_group->m_rule_count <= 0)
{
SWSS_LOG_INFO("acl group %s contains 0 rules, waiting for rule creation", acl.m_acl_group_id->c_str());
acl.m_acl_group_id.reset();
return task_need_retry;
}

attr.id = getSaiStage(direction, *(acl_group->m_ip_version), stage);
attr.value.oid = acl_group->m_dash_acl_group_id;
}
Expand Down