[swss]: Wait for vlan intf to start ndppd #10119
Conversation
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
- Make wait_for_link.sh executable
- Break ndppd supervisord configs into separate file
- Allows us to start ndppd only when VLAN table is present
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
|
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
- Use the `wait_for_link.sh` script to delay ndppd start until after the VLAN interface is ready - Avoids issue where ndppd tries to change interface attributes before the interface is ready
202012 version of #10119 Why I did it If the VLAN interface is not up when ndppd starts, it will fail to enable allmulti mode on the interface and be unable to process received NDP packets The following logs are seen: /var/log/syslog.33.gz:Feb 18 10:33:12.825406 sonic INFO swss#/supervisord: ndppd (error) Failed to set allmulti: No such device How I did it Use the wait_for_link script currently used by radv to delay ndppd startup until the vlan interface is ready How to verify it Apply the changes to a device. config reload the device and confirm that the above error logs are not observed when ndppd starts. Run the arp/test_arp_dualtor.py::test_proxy_arp test case and verify it passes.
202012 version of #10119 Why I did it If the VLAN interface is not up when ndppd starts, it will fail to enable allmulti mode on the interface and be unable to process received NDP packets The following logs are seen: /var/log/syslog.33.gz:Feb 18 10:33:12.825406 sonic INFO swss#/supervisord: ndppd (error) Failed to set allmulti: No such device How I did it Use the wait_for_link script currently used by radv to delay ndppd startup until the vlan interface is ready How to verify it Apply the changes to a device. config reload the device and confirm that the above error logs are not observed when ndppd starts. Run the arp/test_arp_dualtor.py::test_proxy_arp test case and verify it passes.
|
Hi @theasianpianist @prsunny, there was a similar PR 9476 that I created before to check PortInitDone, what I was thinking is whether the XXXsyncd/XXXmgrd should not be started until the PortInitDone being presented? |
@prsunny can you comment on this? |
This change seems to be impactful and has to be tested with warmboot scenarios etc before confirming. |
Second try for PR #10036 (had to be reverted due to a bug)
Why I did it
If the VLAN interface is not up when ndppd starts, it will fail to enable
allmultimode on the interface and be unable to process received NDP packetsThe following logs are seen:
How I did it
Use the
wait_for_linkscript currently used byradvto delay ndppd startup until the vlan interface is readyHow to verify it
Apply the changes to a device.
config reloadthe device and confirm that the above error logs are not observed when ndppd starts. Run thearp/test_arp_dualtor.py::test_proxy_arptest case and verify it passes.Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)