[swss] Add an oneshot service to present the portInitDone state #9476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azpw run |
|
/AzurePipelines run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
gord1306
force-pushed
the
portinitdone
branch
3 times, most recently
from
998db2d
to
aba3da8
Compare
There are services may use netlink to communiate with kernel, but not all of services check the PortInitDone. That mesans these services would be start when netdev is unstable. For buffermgrd, it checks the PortInitDone being written into the PORT_TABLE of APPL_DB before starting. But to implement duplicated check in the other services would cause the duplicated code. This patch would like to add a oneshot service - portinitdone to present the system is in the PortInitDone state. And move some services be back of this service Signed-off-by: gord_chen <gord_chen@edge-core.com>
gord1306
force-pushed
the
portinitdone
branch
from
aba3da8
to
44025e0
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
There are services may use netlink to communiate with kernel, but
not all of services check the PortInitDone. That mesans these services
would be start when netdev is unstable. For buffermgrd, it checks
the PortInitDone being written into the PORT_TABLE of APPL_DB before
starting. But to implement duplicated check in the other services
would cause the duplicated code. This patch would like to add a
oneshot service - portinitdone to present the system is in the
PortInitDone state. And move some services be back of this service
Signed-off-by: gord_chen gord_chen@edge-core.com
How I did it
How to verify it
Check the services of swss could be startup successfully
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)