[swss]: Wait for vlan intf to start ndppd #10036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
prsunny
reviewed
Feb 19, 2022
| # Wait for the interface to come up | ||
| # (i.e., interface is present in STATE_DB and state is "ok") | ||
| while true; do | ||
| RESULT=$(sonic-db-cli STATE_DB HGET "${TABLE_PREFIX}|${IFACE}" "state" 2> /dev/null) |
There was a problem hiding this comment.
During SWSS init, there is a cleanup of STATE_DB tables. Can you please confirm, this script is always executed after that cleanup?
There was a problem hiding this comment.
This script waits for swssconfig.sh to exit, and swssconfig.sh waits for the /ready flag which is only created after the DBs are cleared
There was a problem hiding this comment.
So just to confirm, ndppd won't get started on a T1 topology with this change, right?
|
/Azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/Azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/Azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
approved these changes
Feb 25, 2022
theasianpianist
added a commit
that referenced
this pull request
Feb 25, 2022
This reverts commit 9120487.
theasianpianist
added a commit
that referenced
this pull request
Feb 28, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lawrence Lee lawlee@microsoft.com
Why I did it
If the VLAN interface is not up when ndppd starts, it will fail to enable
allmultimode on the interface and be unable to process received NDP packetsThe following logs are seen:
How I did it
Use the
wait_for_linkscript currently used byradvto delay ndppd startup until the vlan interface is readyHow to verify it
Apply the changes to a device.
config reloadthe device and confirm that the above error logs are not observed when ndppd starts. Run thearp/test_arp_dualtor.py::test_proxy_arptest case and verify it passes.Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)