-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
semi-colons are not removed when import('./file') is used #3
Comments
What eslint or prettier configuration can fix it? |
Hmm, it seems semicolons won't be removed if eslint encounters syntax error while parsing.. |
@faceyspacey This needs to be fixed in here: https://github.com/prettier/prettier-eslint/issues Could you raise this issue there? |
I think I'm having a similar issue. Semicolons are not removed when I have ES6 classes with state = {
...
}
startRecording = (data) => {
...
} I tried using I have "eslintConfig": {
"plugins": [
"babel"
],
"rules": {
"babel/semi": [
"error",
"never"
]
}
}, |
@flybayer Could you raise this issue to https://github.com/prettier/prettier-eslint/issues ? |
@flybayer thanks for the head's up on the relevant tickets. babel/eslint-plugin-babel#121 was merged and the test case supplied outlines an appropriate Once that's in place and |
@justsee thank you for the .eslintrc link! I got it working! On top of Then add this to "eslintConfig": {
"parser": "babel-eslint",
"plugins": [
"babel"
],
"rules": {
"babel/semi": [
2,
"never"
]
}
}
|
This is unfortunate as now it means you cannot use prettier-standard out of the gate with any project without configuration. Will this no longer be relevant when |
I'll try to keep this module useful without configuration. Going to update
in upcoming days
…On Mon, 17 Apr 2017 at 02:56, Dana Woodman ***@***.***> wrote:
This is unfortunate as now it means you can use prettier-standard out of
the gate with any project without configuration. Will this no longer be
relevant when prettier-eslint fixes things or is this always going to be
the case?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAR2DRSnn6_x9ZjuiWLT_2BWKZjWSvTZks5rwri4gaJpZM4MmFUG>
.
|
This issue on prettier-eslint needs to be fixed first, please help to make it so: |
@faceyspacey This should be fixed in 4.1.0, could you check? |
Also, please feel free to add yourself to contributors list |
@sheerun nice, this seems to do it! Thanks! 🍻 |
It appears the new
import().next
syntax breaks prettier-standard--at least when using it without an.eslintrc.js
file.The text was updated successfully, but these errors were encountered: