Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Use prettier v1, update babel configs #6

Closed
wants to merge 7 commits into from
Closed

feat(core): Use prettier v1, update babel configs #6

wants to merge 7 commits into from

Conversation

justingreenberg
Copy link

@justingreenberg justingreenberg commented Apr 15, 2017

  • (deps) updates pretter-eslint to v5+ (prettier v1 engine)
  • (feature) use prettier AST formatter for handling semi and single-quotes
  • (babel) replace preset-node-module with preset-env
  • (babel) use fast-async promise for async/await control flow in node v4 LTS
  • (babel) remove unnecessary runtime dependencies (ie regeneratorRuntime)

resolves #3

shouldn't be any breaking changes, could ship a patch release :)

@justingreenberg justingreenberg changed the title feat(core): update to use prettier v1! feat(core): Use latest prettier, update babel config (v1) Apr 15, 2017
@justingreenberg justingreenberg changed the title feat(core): Use latest prettier, update babel config (v1) feat(core): Use prettier v1, update babel configs Apr 17, 2017
@sheerun
Copy link
Owner

sheerun commented Apr 18, 2017

This PR does much more than updating prettier to 1.0. If you'd like other to introduce other changes I'm open for discussion. For now I'm committing prettier upgrade directly to master. btw. this is a breaking change as shown by changed src/format-files.test.js so major bump is necessary

@sheerun sheerun closed this in 10f45ee Apr 18, 2017
@sheerun
Copy link
Owner

sheerun commented Apr 18, 2017

Thank you, by the way! :) Feel free to add yourself to contributors list and send another PR

@justingreenberg
Copy link
Author

@sheerun cheers dude—happy to see v1 integrated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

semi-colons are not removed when import('./file') is used
2 participants