This repository has been archived by the owner on Aug 4, 2020. It is now read-only.
Add babel semi #121
Merged
Add babel semi #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronjensen
force-pushed
the
add-babel-semi
branch
from
3ac17b4
to
df74913
Compare
aaronjensen
force-pushed
the
add-babel-semi
branch
from
df74913
to
a98accb
Compare
kentcdodds
approved these changes
Feb 27, 2017
There was a problem hiding this comment.
Super! I'm not sure when I got review privileges here, but here I am, leaving a LGTM review! I need this for: prettier/prettier-eslint#32
Thanks!
|
|
||
| // babel, "never" | ||
| { code: "class Foo { bar = 'example' }", options: ["never"] }, | ||
| { code: "class Foo { static bar = 'example' }", options: ["never"] } |
|
Also, I created a minimal reproducible example of the issue I referenced and when I use this branch against my code it is able to fix everything as expected: kentcdodds/eslint-fix-public-class-fields-semi@6628a70 |
nicolo-ribaudo
pushed a commit
to babel/babel
that referenced
this pull request
Nov 14, 2019
* Add semi from eslint * Add ClassProperty support to semi rule Fixes babel/eslint-plugin-babel#43
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43