provide possibility to set up data dir(Rebased to newest version) #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebase to Main branch of parent project
|
Would appreciate any feedback :) @ckipp01 |
ckipp01
requested changes
Sep 10, 2021
There was a problem hiding this comment.
Thanks a lot for this @pzhong-livongo! Just a quick suggestion on the description and a question on super.
Co-authored-by: Chris Kipp <ckipp@pm.me>
ckipp01
approved these changes
Sep 13, 2021
|
@ckipp01 Thank you so much for merging this. Would it be possible for a new version to be published? |
Scala 2.12.15 should be out any day, so as soon as that's released I'll cut a new version of the scalac-plugin and then this as well. So if you can wait (hopefully a week or so), then this will be released along with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull #262 previously did most of the ground work, but this is now rebased to the newest version of sbt-scoverage.