Update sbt-scoverage to 1.9.0

[scala-steward]

Updates org.scoverage:sbt-scoverage from 1.8.2 to 1.9.0.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scoverage", artifactId = "sbt-scoverage" } ]

labels: sbt-plugin-update, semver-minor

[SethTisue]

@tpolecat why closed? I was hoping this would be merged because then in the Scala community build, we could move skunk off sbt 1.5.5 onto 1.6.0-M1

[tpolecat]

I'm consolidating all the library updates, should get to it tomorrow.

[tpolecat]

This upgrade doesn't work. It blows up with references to unknown settings, as seen in the failed CI above. The error refers to keys that aren't present anywhere in my build.

[SethTisue]

weird

Runtime references to undefined settings: 
  circeJS / Compile / coverageDataDir from coverageAggregate ((scoverage.ScoverageSbtPlugin.projectSettings) ScoverageSbtPlugin.scala:62)
  testsJS / Compile / coverageDataDir from coverageAggregate ((scoverage.ScoverageSbtPlugin.projectSettings) ScoverageSbtPlugin.scala:62)
  refinedJS / Compile / coverageDataDir from coverageAggregate ((scoverage.ScoverageSbtPlugin.projectSettings) ScoverageSbtPlugin.scala:62)
  coreJS / Compile / coverageDataDir from coverageAggregate ((scoverage.ScoverageSbtPlugin.projectSettings) ScoverageSbtPlugin.scala:62)

presumably related to scoverage/sbt-scoverage#366

maybe @pzhong-livongo or @ckipp01 has some insight?

[ckipp01]

maybe @pzhong-livongo or @ckipp01 has some insight?

Taking a quick look, yea I believe I see the issue. Those 4 build targets correspond to the four in skunk that have .disablePlugins(ScoverageSbtPlugin) and in our aggregateFilter we have inAggregates(ThisProject) when instead we should only be targeting the modules that are enabled. I'll try to fix this and follow-up back up here with an update.

[ckipp01]

Alright, 1.9.1 was just published and should be on its way. Locally I tested with skunk and it all seems good.