provide possibility to set up data dir #262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 18, 2018 15:06
|
This should solve the issue #224 (comment) by the setting up data directory. |
|
@gslowikowski I will glad if you can consider merging this feature as well. |
|
Will this ever be merged? |
|
I'm interested as well - what's blocking the merge? |
tfreiling
reviewed
Jul 16, 2020
| @@ -77,7 +78,7 @@ object ScoverageSbtPlugin extends AutoPlugin { | |||
| } | |||
| Seq( | |||
| Some(s"-Xplugin:${pluginPath.getAbsolutePath}"), | |||
| Some(s"-P:scoverage:dataDir:${crossTarget.value.getAbsolutePath}/scoverage-data"), | |||
| Some(s"-P:scoverage:dataDir:${coverageDataDir.value.getAbsolutePath}/scoverage-data"), | |||
There was a problem hiding this comment.
Probably remove the /scoverage-data part, as this can be set by the dataDir
|
Hello! If there is still an interest in getting this merged, feel free to rebase and I can take a look at this. |
|
If someone is interested in this can take it over. |
|
I just created a new PR where it's rebasing the latest master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes which I requested in issue #261
I hope it will be helpful.