Remove ExampleUI (pages, components, assets, content) #578
Conversation
It always feels good to remove things :-) |
|
@carletex I found a small comment about the example UI in the README page:
|
carletex
force-pushed
the
576#remove-example-ui
branch
from
dcb9576
to
f3486b5
Compare
Good catch Damu! Removed it on f3486b5 |
There was a problem hiding this comment.
We can remove react-fast-marquee
and maybe this rule too ( not sure about this weather to keep this or not) :
apart from this I think everything is removed 🙌
This feels good haha. Please check that I'm not missing anything that ExampleUI was using and I didn't remove.
We could wait to merge this until we have a v0.1 of scaffold-eth/se2-docs#25.... or not 😇
I think maybe we could merge this 🙌 since we already have all isolated examples of hooks in docs.... not that verbose how it will be recipe section but I think they are good
P.S. Shoutout to @rin-st who did a great job implementing it in the first place :)
🫡🫡
Tysm Carlos 🙌
|
Looks good to me! |
|
Good eye @technophile-04 !! Remove the lib and the eslint rule. Thanks all for the review! I'll let you guys merge after reviewing the last two commits :) |
|
LGTM! Tysm Carlos and all for reviews !! Merging this 🙌 |
* Tweak DaisyUI `link` (#560) * Improve ENS support (accept all TLDs) (#563) * fix: memo history events (#565) Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com> * Extract header menu links (#570) * Move Block Explorer to footer (#574) * Remove ExampleUI (pages, components, assets, content) (#578) * update wagmi, viem, rainbowkit (#580) * add zkSync, scroll & polygonZkEvm to foundry.toml * add changeset --------- Co-authored-by: Filip Harald <Filip.harald@gmail.com> Co-authored-by: Greg <35093316+gskril@users.noreply.github.com> Co-authored-by: Rinat <rinat@hey.com> Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>
Fixes #576
This feels good haha. Please check that I'm not missing anything that ExampleUI was using and I didn't remove.
We could wait to merge this until we have a v0.1 of scaffold-eth/se-2-docs#25.... or not 😇
P.S. Shoutout to @rin-st who did a great job implementing it in the first place :)