Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract headerMenuLinks from Header (inline variation) #570

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

carletex
Copy link
Member

Fixes #568

Same as #569 but inlining the menu array (instead of extracting it to a diff file)

Copy link
Collaborator

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tysm Carlos 🙌 this looks nice to me!

@carletex carletex merged commit 57fbb41 into main Oct 12, 2023
1 check passed
@carletex carletex deleted the extract-main-menu-links-same-file branch October 12, 2023 17:27
carletex added a commit that referenced this pull request Oct 23, 2023
* Tweak DaisyUI `link` (#560)

* Improve ENS support (accept all TLDs) (#563)

* fix: memo history events (#565)

Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>

* Extract header menu links (#570)

* Move Block Explorer to footer (#574)

* Remove ExampleUI (pages, components, assets, content) (#578)

* update wagmi, viem, rainbowkit (#580)

* add zkSync, scroll & polygonZkEvm to foundry.toml

* add changeset

---------

Co-authored-by: Filip Harald <Filip.harald@gmail.com>
Co-authored-by: Greg <35093316+gskril@users.noreply.github.com>
Co-authored-by: Rinat <rinat@hey.com>
Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>
@github-actions github-actions bot mentioned this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract header main menu link to a more accesible place.
3 participants