Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Block Explorer to footer #574

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Move Block Explorer to footer #574

merged 2 commits into from
Oct 18, 2023

Conversation

carletex
Copy link
Member

@carletex carletex commented Oct 13, 2023 •
edited
Loading

For the sake of cleaning up the UI a bit (Example UI might be next :D Will create an issue soon), I'm testing moving the Block Explorer from the main menu to the footer. You still have access in any page (+ in the TX notifications) but in a less intrusive way. It will only show on dev env (local network), like the Faucet.

image
image

Anyway, just tinkering. Let me know what you think!

rin-st
rin-st approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@rin-st rin-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the way it looks now 👍

Pabl0cks
Pabl0cks approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great to me 🙌

technophile-04
technophile-04 approved these changes Oct 14, 2023
View reviewed changes
Copy link
Collaborator

@technophile-04 technophile-04 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really looks clean !! and also now we don't have to manually remove Block Explorer it will be automatically removed if switched to other network 🙌

Tysm Carlos !!

Nitpick :

Screenshot 2023-10-14 at 6 38 54 PM

Maybe we should keep the same spacing b/w text icons for all buttons?

@carletex
Copy link
Member Author

Maybe we should keep the same spacing b/w text icons for all buttons?

Changed to use the same classes (and removed some that weren't doing anything). Visually it doesn't look 100% aligned, because the 16x16 icons have some air around and the "bankNote" one is wider than the other two... also, the "1" gives the feeling of being more on the right than "F" or "B"

Anyway, this is how it looks:

image

@carletex
Copy link
Member Author

Thanks all for the review!

Feel free to merge when checking the last commit.

@Pabl0cks
Copy link
Collaborator

Looks great to me! But I'll let Shiv's with his hawk-eye have the last word 🧐

@technophile-04
Copy link
Collaborator

Visually it doesn't look 100% aligned, because the 16x16 icons have some air around and the "bankNote" one is wider than the other two... also, the "1" gives the feeling of being more on the right than "F" or "B"

Ohh yes, that makes sense! I think it looks fine 🙌

Also, SE-2 will be mostly viewed on mobile if it's in prod (i.e no hardhat network) so both Facuet and Blockexplorer shouldn't show up on mobile 🙈 lol sorry for my OCD kicking in

Tysm Carlos 🙏 look great to me 🙌

@technophile-04 technophile-04 merged commit aec2b8c into main Oct 18, 2023
1 check passed
@technophile-04 technophile-04 deleted the move-blockexplorer branch October 18, 2023 05:36
@technophile-04 technophile-04 mentioned this pull request Oct 23, 2023
Merged
carletex added a commit that referenced this pull request Oct 23, 2023
@technophile-04 @FilipHarald
@gskril @rin-st @carletex
backmerge latest change to cli (#582)
30d9000 
* Tweak DaisyUI `link` (#560)

* Improve ENS support (accept all TLDs) (#563)

* fix: memo history events (#565)

Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>

* Extract header menu links (#570)

* Move Block Explorer to footer (#574)

* Remove ExampleUI (pages, components, assets, content) (#578)

* update wagmi, viem, rainbowkit (#580)

* add zkSync, scroll & polygonZkEvm to foundry.toml

* add changeset

---------

Co-authored-by: Filip Harald <Filip.harald@gmail.com>
Co-authored-by: Greg <35093316+gskril@users.noreply.github.com>
Co-authored-by: Rinat <rinat@hey.com>
Co-authored-by: Carlos Sánchez <oceanrdn@gmail.com>
@github-actions github-actions bot mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pabl0cks Pabl0cks Pabl0cks approved these changes

@rin-st rin-st rin-st approved these changes

@technophile-04 technophile-04 technophile-04 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carletex @Pabl0cks @technophile-04 @rin-st