-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 9 pull requests #114869
Rollup of 9 pull requests #114869
Commits on Aug 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 971427e - Browse repository at this point
Copy the full SHA 971427eView commit details
Commits on Aug 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 591b547 - Browse repository at this point
Copy the full SHA 591b547View commit details
Commits on Aug 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b75351e - Browse repository at this point
Copy the full SHA b75351eView commit details
Commits on Aug 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for dc9b61d - Browse repository at this point
Copy the full SHA dc9b61dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c3889d1 - Browse repository at this point
Copy the full SHA c3889d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8bda18 - Browse repository at this point
Copy the full SHA f8bda18View commit details
Commits on Aug 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1b6cf74 - Browse repository at this point
Copy the full SHA 1b6cf74View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29a1e46 - Browse repository at this point
Copy the full SHA 29a1e46View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa6c02d - Browse repository at this point
Copy the full SHA aa6c02dView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe6d541 - Browse repository at this point
Copy the full SHA fe6d541View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb07077 - Browse repository at this point
Copy the full SHA fb07077View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f21e6d - Browse repository at this point
Copy the full SHA 9f21e6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for a826cdb - Browse repository at this point
Copy the full SHA a826cdbView commit details -
Document Default for ExitStatus
This lets us put a version on the impl, too.
Configuration menu - View commit details
-
Copy full SHA for a741a5a - Browse repository at this point
Copy the full SHA a741a5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e1e6c00 - Browse repository at this point
Copy the full SHA e1e6c00View commit details -
Rollup merge of rust-lang#114588 - ijackson:exit-status-default-2, r=…
…m-ou-se Improve docs for impl Default for ExitStatus This addresses a review comment in rust-lang#106425 (which is on the way to being merged I think). Some of the other followup work is more complicated so I'm going to do individual MRs. ~~Note this branch is on top of rust-lang#106425~~
Configuration menu - View commit details
-
Copy full SHA for 5692c94 - Browse repository at this point
Copy the full SHA 5692c94View commit details -
Rollup merge of rust-lang#114619 - g0djan:godjan/fix_#114608, r=m-ou-se
Fix pthread_attr_union layout on Wasi Fixes rust-lang#114608 Ran the tests as described in https://github.com/rust-lang/rust/blob/master/src/doc/rustc/src/platform-support/wasm32-wasi-preview1-threads.md?plain=1#L125
Configuration menu - View commit details
-
Copy full SHA for 3a88030 - Browse repository at this point
Copy the full SHA 3a88030View commit details -
Rollup merge of rust-lang#114644 - compiler-errors:lt-err, r=wesleywiser
Point out expectation even if we have `TypeError::RegionsInsufficientlyPolymorphic` just a minor tweak, since saying "one type is more general than the other" kinda sucks if we don't actually point out two types.
Configuration menu - View commit details
-
Copy full SHA for 8f1369e - Browse repository at this point
Copy the full SHA 8f1369eView commit details -
Rollup merge of rust-lang#114721 - danflapjax:bool-ord-optimization, …
…r=cuviper Optimizing the rest of bool's Ord implementation After coming across issue rust-lang#66780, I realized that the other functions provided by Ord (`min`, `max`, and `clamp`) were similarly inefficient for bool. This change provides implementations for them in terms of boolean operators, resulting in much simpler assembly and faster code. Fixes issue rust-lang#114653 [Comparison on Godbolt](https://rust.godbolt.org/z/5nb5P8e8j) `max` assembly before: ```assembly example::max: mov eax, edi mov ecx, eax neg cl mov edx, esi not dl cmp dl, cl cmove eax, esi ret ``` `max` assembly after: ```assembly example::max: mov eax, edi or eax, esi ret ``` `clamp` assembly before: ```assembly example::clamp: mov eax, esi sub al, dl inc al cmp al, 2 jae .LBB1_1 mov eax, edi sub al, sil movzx ecx, dil sub dil, dl cmp dil, 1 movzx edx, dl cmovne edx, ecx cmp al, -1 movzx eax, sil cmovne eax, edx ret .LBB1_1: ; identical assert! code ``` `clamp` assembly after: ```assembly example::clamp: test edx, edx jne .LBB1_2 test sil, sil jne .LBB1_3 .LBB1_2: or dil, sil and dil, dl mov eax, edi ret .LBB1_3: ; identical assert! code ```
Configuration menu - View commit details
-
Copy full SHA for 1f28a76 - Browse repository at this point
Copy the full SHA 1f28a76View commit details -
Rollup merge of rust-lang#114822 - GuillaumeGomez:code-readability-im…
…provement, r=notriddle Improve code readability by moving fmt args directly into the string There are some of occurrences where I also transformed `write!(f, "{}", x)` into `f.write_str(x.as_str())`. r? `@notriddle`
Configuration menu - View commit details
-
Copy full SHA for ffabd64 - Browse repository at this point
Copy the full SHA ffabd64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4915a3e - Browse repository at this point
Copy the full SHA 4915a3eView commit details -
Rollup merge of rust-lang#114837 - RalfJung:error_in_core, r=cuviper
add missing feature(error_in_core) Needed to fix feature gate errors in https://github.com/rust-lang/miri-test-libstd/actions/runs/5862810459/job/15895203359. I don't know how doctests are passing in-tree without this feature gate...
Configuration menu - View commit details
-
Copy full SHA for 27e92e3 - Browse repository at this point
Copy the full SHA 27e92e3View commit details -
Rollup merge of rust-lang#114853 - GuillaumeGomez:migrate-gui-test-co…
…lor-33, r=notriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang#111459. r? ```@notriddle```
Configuration menu - View commit details
-
Copy full SHA for 1261a7f - Browse repository at this point
Copy the full SHA 1261a7fView commit details -
Rollup merge of rust-lang#114861 - RalfJung:no-effect, r=wesleywiser
fix typo: affect -> effect I just realized I made a silly typo when writing that comment...
Configuration menu - View commit details
-
Copy full SHA for 8ebf823 - Browse repository at this point
Copy the full SHA 8ebf823View commit details