Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update browser-ui-test version to 0.16.0 #111459

Merged
merged 3 commits into from
May 12, 2023

Conversation

GuillaumeGomez
Copy link
Member

This new version brings one major improvement: it allows to use the original color format in checks (I plan to slowly continue converting colors back to their "original" format, ie the one used in CSS).

It also provides some improvements in some commands API.

r? @notriddle

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels May 11, 2023
store-property: (index_sidebar_width, ".sidebar .location a", "clientWidth")
store-property: (index_sidebar_height, ".sidebar .location a", "clientHeight")
store-property: (index_sidebar_x, ".sidebar .location a", "offsetTop")
store-property: (index_sidebar_y, ".sidebar .location a", "offsetLeft")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, past me. 🤦‍♂️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, nice job to past me as well for not seeing it when reviewing. 😛

@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 11, 2023

📌 Commit 8e55400 has been approved by notriddle

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented May 11, 2023

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 11, 2023
…est, r=notriddle

Update browser-ui-test version to 0.16.0

This new version brings one major improvement: it allows to use the original color format in checks (I plan to slowly continue converting colors back to their "original" format, ie the one used in CSS).

It also provides some improvements in some commands API.

r? `@notriddle`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 11, 2023
…est, r=notriddle

Update browser-ui-test version to 0.16.0

This new version brings one major improvement: it allows to use the original color format in checks (I plan to slowly continue converting colors back to their "original" format, ie the one used in CSS).

It also provides some improvements in some commands API.

r? ``@notriddle``
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 11, 2023
…est, r=notriddle

Update browser-ui-test version to 0.16.0

This new version brings one major improvement: it allows to use the original color format in checks (I plan to slowly continue converting colors back to their "original" format, ie the one used in CSS).

It also provides some improvements in some commands API.

r? ```@notriddle```
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 11, 2023
…est, r=notriddle

Update browser-ui-test version to 0.16.0

This new version brings one major improvement: it allows to use the original color format in checks (I plan to slowly continue converting colors back to their "original" format, ie the one used in CSS).

It also provides some improvements in some commands API.

r? ````@notriddle````
bors added a commit to rust-lang-ci/rust that referenced this pull request May 12, 2023
…mpiler-errors

Rollup of 7 pull requests

Successful merges:

 - rust-lang#106038 (use implied bounds when checking opaque types)
 - rust-lang#111366 (Make `NonUseContext::AscribeUserTy` carry `ty::Variance`)
 - rust-lang#111375 (CFI: Fix SIGILL reached via trait objects)
 - rust-lang#111439 (Fix backtrace normalization in ice-bug-report-url.rs)
 - rust-lang#111444 (Only warn single-use lifetime when the binders match.)
 - rust-lang#111459 (Update browser-ui-test version to 0.16.0)
 - rust-lang#111460 (Improve suggestion for `self: Box<self>`)

Failed merges:

 - rust-lang#110454 (Require impl Trait in associated types to appear in method signatures)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit eead6f4 into rust-lang:master May 12, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 12, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 20, 2023
…lor-34, r=notriddle

Migrate GUI colors test to original CSS color format

Follow-up of rust-lang#111459.

This test needed more cleanup: first I removed duplication by using a function, then I merge similar rules which had the same values.

r? `@notriddle`
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 21, 2023
…r-35, r=notriddle

Migrate GUI colors test to original CSS color format

Follow-up of rust-lang#111459.

r? `@notriddle`
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Aug 21, 2023
…otriddle

Migrate GUI colors test to original CSS color format

Follow-up of rust-lang/rust#111459.

r? `@notriddle`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 26, 2023
…lor-36, r=notriddle

Migrate GUI colors test to original CSS color format

Follow-up of rust-lang#111459.

r? `@notriddle`
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 3, 2023
…r-37, r=notriddle

Migrate GUI colors test to original CSS color format

Follow-up of rust-lang#111459.

r? `@notriddle`
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Sep 3, 2023
…otriddle

Migrate GUI colors test to original CSS color format

Follow-up of rust-lang/rust#111459.

r? `@notriddle`
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 3, 2023
…lor-38, r=notriddle

Migrate GUI colors test to original CSS color format

Follow-up of rust-lang#111459.

r? `@notriddle`
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 9, 2023
…r-39, r=notriddle

Migrate GUI colors test to original CSS color format

Follow-up of rust-lang#111459.

r? `@notriddle`
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 10, 2023
…r-40, r=notriddle

Migrate GUI colors test to original CSS color format

Follow-up of rust-lang#111459.

r? `@notriddle`
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Sep 12, 2023
…otriddle

Migrate GUI colors test to original CSS color format

Follow-up of rust-lang/rust#111459.

r? `@notriddle`
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Sep 12, 2023
…otriddle

Migrate GUI colors test to original CSS color format

Follow-up of rust-lang/rust#111459.

r? `@notriddle`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 16, 2023
…lor-41, r=notriddle

Migrate GUI colors test to original CSS color format

Follow-up of rust-lang#111459.

r? `@notriddle`
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 16, 2023
Rollup merge of rust-lang#115890 - GuillaumeGomez:migrate-gui-test-color-41, r=notriddle

Migrate GUI colors test to original CSS color format

Follow-up of rust-lang#111459.

r? `@notriddle`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 23, 2023
…lor-42, r=notriddle

Migrate GUI colors test to original CSS color format

Follow-up of rust-lang#111459.

And with this one I'm finally done with this migration.

r? `@notriddle`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 23, 2023
…lor-42, r=notriddle

Migrate GUI colors test to original CSS color format

Follow-up of rust-lang#111459.

And with this one I'm finally done with this migration.

r? ``@notriddle``
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 24, 2023
Rollup merge of rust-lang#116106 - GuillaumeGomez:migrate-gui-test-color-42, r=notriddle

Migrate GUI colors test to original CSS color format

Follow-up of rust-lang#111459.

And with this one I'm finally done with this migration.

r? ``@notriddle``
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Apr 7, 2024
…otriddle

Migrate GUI colors test to original CSS color format

Follow-up of rust-lang/rust#111459.

r? `@notriddle`
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 27, 2024
…otriddle

Migrate GUI colors test to original CSS color format

Follow-up of rust-lang/rust#111459.

r? `@notriddle`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants