add missing feature(error_in_core) #114837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cuviper (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This was referenced Aug 15, 2023
waynr
reviewed
Aug 15, 2023
| @@ -130,6 +130,7 @@ pub trait Error: Debug + Display { | |||
| /// | |||
| /// ```rust | |||
| /// #![feature(error_generic_member_access)] | |||
| /// #![feature(error_in_core)] | |||
There was a problem hiding this comment.
Would it make more sense to change the import to std::error::{...}? If we don't do that then stabilization of the error_generic_member_access feature would be unnecessarily dependent on error_in_core, right?
There was a problem hiding this comment.
I don't have a preference, I assumed these tests were importing core::error for a reason.
If we don't do that then stabilization of the error_generic_member_access feature would be unnecessarily dependent on error_in_core, right?
No, the functions can still be stabilized independently.
There was a problem hiding this comment.
These are already a mix of core/std, having impl std::error::Error below, but oh well...
3 tasks
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 15, 2023
add missing feature(error_in_core) Needed to fix feature gate errors in https://github.com/rust-lang/miri-test-libstd/actions/runs/5862810459/job/15895203359. I don't know how doctests are passing in-tree without this feature gate...
This was referenced Aug 15, 2023
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 15, 2023
add missing feature(error_in_core) Needed to fix feature gate errors in https://github.com/rust-lang/miri-test-libstd/actions/runs/5862810459/job/15895203359. I don't know how doctests are passing in-tree without this feature gate...
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 15, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#114588 (Improve docs for impl Default for ExitStatus) - rust-lang#114619 (Fix pthread_attr_union layout on Wasi) - rust-lang#114644 (Point out expectation even if we have `TypeError::RegionsInsufficientlyPolymorphic`) - rust-lang#114668 (Deny `FnDef` in patterns) - rust-lang#114819 (Point at return type when it influences non-first `match` arm) - rust-lang#114826 (Fix typos) - rust-lang#114837 (add missing feature(error_in_core)) - rust-lang#114853 (Migrate GUI colors test to original CSS color format) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to fix feature gate errors in https://github.com/rust-lang/miri-test-libstd/actions/runs/5862810459/job/15895203359. I don't know how doctests are passing in-tree without this feature gate...