Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added clients by node implementation from rcl #383

Merged
merged 8 commits into from
Jul 9, 2019
Merged

Added clients by node implementation from rcl #383

merged 8 commits into from
Jul 9, 2019

Conversation

skucheria
Copy link
Member

@skucheria skucheria commented Jul 3, 2019 •
edited
Loading

Connects to ros2/sros2#141

Requires ros2/rcl#459

@skucheria
adding client_names_and_types_by_node
d6fadd0 
Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
@skucheria
small fix
1c07b32 
Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
@skucheria
function description
b90941c 
Signed-off-by: Siddharth Kucheria <kucheria@usc.edu>
@skucheria skucheria marked this pull request as ready for review July 3, 2019 18:03
@skucheria skucheria mentioned this pull request Jul 3, 2019
Merged
jacobperron
jacobperron reviewed Jul 8, 2019
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. Also, add a smoke test for the new node method, similar to get_service_names_and_types.

rclpy/rclpy/node.py Show resolved Hide resolved
rclpy/rclpy/node.py Outdated Show resolved Hide resolved
rclpy/src/rclpy/_rclpy.c Outdated Show resolved Hide resolved
rclpy/src/rclpy/_rclpy.c Show resolved Hide resolved
skucheria and others added 4 commits July 8, 2019 10:41
@skucheria @jacobperron
Update rclpy/rclpy/node.py
701c84f 
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
@skucheria @jacobperron
Update rclpy/src/rclpy/_rclpy.c
616f241 
Co-Authored-By: Jacob Perron <jacob@openrobotics.org>
@skucheria
minor changes
b225b98
@skucheria
Update node.py
16f480e
jacobperron
jacobperron approved these changes Jul 8, 2019
View reviewed changes
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments to address, otherwise LGTM with green CI 👍

rclpy/test/test_node.py Outdated Show resolved Hide resolved
rclpy/test/test_node.py Show resolved Hide resolved
@skucheria
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@skucheria skucheria merged commit 79d8b2b into master Jul 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the kucheria/clients_by_node branch July 9, 2019 16:32
@wjwwood
Copy link
Member

wjwwood commented Jul 11, 2019

I believe this introduced a regression in our nightlies:

https://ci.ros2.org/view/nightly/job/nightly_linux_release/1232/testReport/junit/(root)/projectroot/flake8/

I don't understand why, though because I don't see the trailing whitespace on line 182...

@wjwwood wjwwood mentioned this pull request Jul 11, 2019
Merged
@wjwwood
Copy link
Member

wjwwood commented Jul 11, 2019

It's definitely there, but I don't know that this pr was the culprit: #385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skucheria @wjwwood @jacobperron