Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove whitespace #385

Merged
merged 1 commit into from
Jul 11, 2019
Merged

remove whitespace #385

merged 1 commit into from
Jul 11, 2019

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Jul 11, 2019

This is causing all of our nightly jobs to be unstable, e.g.:

https://ci.ros2.org/view/nightly/job/nightly_linux_release/1232/testReport/junit/(root)/projectroot/flake8/

I think it's a follow up of #383, but I'm not sure.

Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood added the bug Something isn't working label Jul 11, 2019
@wjwwood wjwwood self-assigned this Jul 11, 2019
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it is from #383 (according to git annotate).

@wjwwood
Copy link
Member Author

wjwwood commented Jul 11, 2019

Yeah, it's just weird because I don't see it in the github diff for the pr, and the CI settings for that job looked ok to me.

@wjwwood wjwwood merged commit 29c2bac into master Jul 11, 2019
@wjwwood wjwwood deleted the remove_whitespace branch July 11, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants