urdfdom compatibility #1064
urdfdom compatibility #1064
Conversation
... relying on the compatibility layer of urdf package
|
Wow thanks @rhaschke, I was expecting to do this today. I appreciate you opening the pr! The code changes lgtm, I need to do a build on Wily real quick to test it. |
|
You are welcome. I was working on that anyway. Please also have a look at ros/urdfdom_headers#33. The most annoying incompatibility was the new |
|
Is ros/urdfdom_headers#33 necessary for these pr's to get merged? I would think not (since we probably cannot get those changes released into Debian/Ubuntu at this point). |
|
No, it's not. There is a workaround in the compatiblity header to also define the |
| @@ -39,8 +39,7 @@ | |||
| #include <OgreQuaternion.h> | |||
| #include <OgreAny.h> | |||
|
|
|||
| #include <urdf_model/types.h> | |||
| #include <urdf_world/types.h> | |||
| #include <urdf/model.h> // can be replaced later by urdf_model/types.h | |||
There was a problem hiding this comment.
This can be changed to include urdf_model/types.h as soon as ros/urdfdom_headers#33 is merged.
|
I tested this manually on Wily with ros/robot_model#160. Thanks again @rhaschke! |
|
Is it possible to also merge this into indigo-devel? |
|
@languitar maybe, why do you need it though? |
|
At least on archlinux I am unable to compile indigo desktop without this fix. |
|
That's probably because archlinux has a newer version of I'll consider backporting it next time I do a release, but honestly you should update to Kinetic if you're using the latest dependency versions on arch. |
|
Sure, I'd like to if everything I wanted to try worked well with that version. |
I assume you mean, something that you're using doesn't support Kinetic? For me there's three things you could do:
I'll see what I can do, but please put pressure on the upstream thing to support Kinetic too. |
* Use urdf::*ShredPtr instead of boost::shared_ptr (#1044) urdfdom_headers uses C++ std::shared_ptr. As it exports it as custom *SharedPtr type, we can use the to sty compatible. This also adds a proper dependency for urdfdom-headers * adaptions to build against both urdfdom 0.3 and 0.4 ... relying on the compatibility layer of urdf package
|
Backported in #1110 |
* Add fullscreen option. (#1017) * urdfdom compatibility (#1064) * Use urdf::*ShredPtr instead of boost::shared_ptr (#1044) urdfdom_headers uses C++ std::shared_ptr. As it exports it as custom *SharedPtr type, we can use the to sty compatible. This also adds a proper dependency for urdfdom-headers * adaptions to build against both urdfdom 0.3 and 0.4 ... relying on the compatibility layer of urdf package * Update display if empty pointcloud2 is published (#1073) Do not show last point cloud any more, if published point cloud message does not contain any points * Correctly scale the render panel on high resolution displays (#1078) * support multiple material for one link (#1079) * Fixed duplicate property name for Path colors (#1089) See issue #1087. * fix type error in newer versions of urdf (#1098) * Use unique material names for robot links. (#1102) * avoid C++11 feature for back port to indigo
Reapplied #1044, using urdf::SharedPtr instead of explicit boost::shared_ptr.
Fixed compatibility issues with older
urdfdom 0.3, by relying on ros/robot_model#160.