Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Path color not saved in config file #1087

Closed
theonteg opened this issue Mar 19, 2017 · 3 comments
Closed

Path color not saved in config file #1087

theonteg opened this issue Mar 19, 2017 · 3 comments
Labels
bug

Comments

@theonteg
Copy link

As described in the topic of the issue, rviz does not save Path lines color to the config file.

As a result every time i load a config, path lines are the same pink default color.

Is this a bug?
@wjwwood
Copy link
Member

wjwwood commented Mar 21, 2017

It sounds like a bug. Unfortunately I don't have time to verify it and/or look into a fix for it.

You might start by looking at the config's section for the path display and see if there is a field like that in there. If not, then you might need to modify the display plugin for path's to store and use it. Otherwise it might just be a bug in the path display plugin. Either way, you can see the code for it here:

@wjwwood wjwwood added the bug label Mar 21, 2017
@wjwwood wjwwood added this to the untargeted milestone Mar 21, 2017
@hiddewie
Copy link
Contributor

I've just today also run into this bug.

I looked into the code, and it seems related to the fact that in PathDisplay two properties are defined with the name Color. See https://github.com/ros-visualization/rviz/blob/kinetic-devel/src/rviz/default_plugin/path_display.cpp#L99 and https://github.com/ros-visualization/rviz/blob/kinetic-devel/src/rviz/default_plugin/path_display.cpp#L71.

A solution would probably be renaming the pose color as this property should have a different name.

It would be nice to test this when adding properties to a certain display type to check if a property already exists with that name.

@hiddewie hiddewie mentioned this issue Mar 23, 2017
Merged
@romainreignier
Copy link

@hiddewie Thanks for taking the time to fix this issue.
I have faced that issue for several weeks but did not take the time to track the issue and find a fix.
👍

wjwwood pushed a commit that referenced this issue Mar 23, 2017
@hiddewie @wjwwood
Fixed duplicate property name for Path colors (#1089)
1f53c35 
See issue #1087.
@wjwwood wjwwood closed this as completed May 1, 2017
wjwwood pushed a commit that referenced this issue Jun 5, 2017
@hiddewie @wjwwood
Fixed duplicate property name for Path colors (#1089)
73c64a3 
See issue #1087.
wjwwood added a commit that referenced this issue Jun 5, 2017
@wjwwood
indigo-devel backports from kinetic-devel (1.12.9) (#1110)
ba63491 
* Add fullscreen option. (#1017)

* urdfdom compatibility (#1064)

* Use urdf::*ShredPtr instead of boost::shared_ptr (#1044)

urdfdom_headers uses C++ std::shared_ptr. As it exports it as custom
*SharedPtr type, we can use the to sty compatible.

This also adds a proper dependency for urdfdom-headers

* adaptions to build against both urdfdom 0.3 and 0.4

... relying on the compatibility layer of urdf package

* Update display if empty pointcloud2 is published (#1073)

Do not show last point cloud any more, if published point cloud message does not contain any points

* Correctly scale the render panel on high resolution displays (#1078)

* support multiple material for one link (#1079)

* Fixed duplicate property name for Path colors (#1089)

See issue #1087.

* fix type error in newer versions of urdf (#1098)

* Use unique material names for robot links. (#1102)

* avoid C++11 feature for back port to indigo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wjwwood @hiddewie @theonteg @romainreignier