Use urdf::*ShredPtr instead of boost::shared_ptr #1044
Conversation
|
It doesn't look like I wonder why the urdf types were forward declared and if that was necessary. Other than that lingering curiosity, the changes look reasonable to me. Thanks! |
urdfdom_headers uses C++ std::shared_ptr. As it exports it as custom *SharedPtr type, we can use the to sty compatible. This also adds a proper dependency for urdfdom-headers
jspricke
force-pushed
the
urdfdom_headers_fix
branch
from
c1578fb
to
c2cb77a
Compare
|
Fixed the name, thanks for spotting. I was wondering about the forward declarations as well, but they are older then the git, guess it's not needed anymore.
|
|
@jspricke You should explicitly require urdfdom_headers >= 0.4. Before, the typedefs are not available. |
|
Hi Robert, this one is merged already, so feel free to open a new pull
request if needed ;).
|
|
Sorry, I didn't follow up on @rhaschke's comment. Indeed this breaks the build on Wily and Debian Jessie. I guess I need to revert this change or apply a fix like @rhaschke did for |
|
I think I'm going to revert this and open an issue to resolve it in the future. I'm not sure it makes sense to replicate the work in moveit/srdfdom#25 in rviz and every other ROS package that uses urdf. Perhaps this compatibility shim should be put in into |
* Use urdf::*ShredPtr instead of boost::shared_ptr (#1044) urdfdom_headers uses C++ std::shared_ptr. As it exports it as custom *SharedPtr type, we can use the to sty compatible. This also adds a proper dependency for urdfdom-headers * adaptions to build against both urdfdom 0.3 and 0.4 ... relying on the compatibility layer of urdf package
* Use urdf::*ShredPtr instead of boost::shared_ptr (#1044) urdfdom_headers uses C++ std::shared_ptr. As it exports it as custom *SharedPtr type, we can use the to sty compatible. This also adds a proper dependency for urdfdom-headers * adaptions to build against both urdfdom 0.3 and 0.4 ... relying on the compatibility layer of urdf package
* Add fullscreen option. (#1017) * urdfdom compatibility (#1064) * Use urdf::*ShredPtr instead of boost::shared_ptr (#1044) urdfdom_headers uses C++ std::shared_ptr. As it exports it as custom *SharedPtr type, we can use the to sty compatible. This also adds a proper dependency for urdfdom-headers * adaptions to build against both urdfdom 0.3 and 0.4 ... relying on the compatibility layer of urdf package * Update display if empty pointcloud2 is published (#1073) Do not show last point cloud any more, if published point cloud message does not contain any points * Correctly scale the render panel on high resolution displays (#1078) * support multiple material for one link (#1079) * Fixed duplicate property name for Path colors (#1089) See issue #1087. * fix type error in newer versions of urdf (#1098) * Use unique material names for robot links. (#1102) * avoid C++11 feature for back port to indigo
urdfdom_headers uses C++ std::shared_ptr. As it exports it as custom
*SharedPtr type, we can use the to sty compatible.
This also adds a proper dependency for urdfdom-headers