Suggested changes to your joomla-cms PR 4872 #3

zjw · 2015-11-19T17:10:44Z

This fixes:

Message

Database query failed (error # 1091): Can't DROP 'idx_tag'; check that column/key exists SQL=-- Drop obsolete indexes ALTER TABLE `osvlt_contentitem_tag_map` DROP INDEX `idx_tag`;

Database query failed (error # 1091): Can't DROP 'idx_type'; check that column/key exists SQL=ALTER TABLE `osvlt_contentitem_tag_map` DROP INDEX `idx_type`;

Database query failed (error # 0): SQL=

Installation of the file was successful.

It also makes the schema when updating the same as when installing.

These updates are already in: administrator/components/com_admin/sql/updates/mysql/3.5.0-2015-10-26.sql

Without this commit, the conversion doesn't happen when updating from 3.4.5. The db connection used for the conversion will use the utf8 charset, not utf8mb4. But that doesn't matter since we are not sending utf8mb4 characters during the conversion.

zjw · 2015-11-19T18:52:34Z

I've also reinstated pdomysql conversion on update.

Suggested changes to your joomla-cms PR 4872

Fix typos

update from upstream

fix for joomla#7359

remove CCOM and replace with COM

@andrepereiradasilva

… (joomla#12292) * Cleanups, fixes and a bit of optimizations for site/components batch #3 - com_content Note: This is a single commit bundling all types of changes, since PR joomla#12261 which had detailed commits, was rejected as a whole * Ch-Ch-Ch-Changes! Made some changes as pointed out by @andrepereiradasilva * A bit more... * Revert * Removed empty function, as there is a fallback. Change made according to comment from @wilsonge * Included @andrepereiradasilva's suggestions * Inserting whitespace before php closing tag

@shur

* Replace unnecessary double quotes * And one unnecessary semicolon... ;) * CS Fix + removal of unnecessary space * some more double quote replacements * Changes, based on @shur's comments

@mbabker

* Some improvements in tests #3: - call static methods correctly * Fix T_PAAMAYIM_NEKUDOTAYIM (for all PHP 5.x) * Remove forgotten call * Changed a few things after conversation with @mbabker * Fixes according to @andrepereiradasilva's comments

…sets-option * 'staging' of github.com:roland-d/joomla-cms: (136 commits) Clean up old code in cache.php file (joomla#12183) Fixing search for MySQL (joomla#13571) Unnecessary double quotes in /libraries/joomla (joomla#13372) Some improvements in tests #3: (joomla#13402) It's 2017. Happy New Year Fixing a typo in gallery plugin language files Add stripslashes to mssql result columns. (joomla#13534) remove unneeded space from btn-group/radio/checkboxes (joomla#12003) typo (joomla#13563) Remove default value from the field params to inherit from plugin Remove multiple parameter from user field Fix name of component helper in fieldshelper (joomla#13539) remove duplicated code (joomla#13550) Fix invalid string that causes the ini file not to load (joomla#13544) Catch "expects parameter 2 to be string" error Take complete context for group lookup (joomla#13538) [Mssql] Fix syntax error when installing a language in backend (joomla#13512) Normalize #__categories table across 3 db systems and add default values (joomla#13514) Normalize #__ucm_content table across 3 db systems and add default values (joomla#13513) Update config.xml (joomla#13503) ...

* Load correct core files of override files (#2) Start implements loadcorefile() in administrator/components/com_templates/Model/TemplateModel.php * CS (#3) Coding Standards * codingstandards * codingstandards (#4) * Test (#6) Phase 2 (2 part) Mechanism to find correct core file and implementation. * Remove Notice: Only available for html-folder * Remove Warning if core file not found (#11) Thanks. So one part of the issue joomla-projects/gsoc18_override_management#12 is done. * Implement the diff view in template manager Implement the diff view in template manager * coding standard (joomla#17) * fix diff (joomla#18) Fix bug in path in case of administrator template override. Fix bug in path in case of administrator template override. * Notification after update and TEST (joomla#16) Find changed files of overridden files and show message. * coding standard (joomla#21) * correction * correction (joomla#26) * Correcthtmlpath (joomla#27) * correction * change oldhtml to newhtml * List of updated override files. (joomla#30) * addcss (joomla#34) * Final Product (joomla#39) Core and Diff view Updated override history list. Quick icon notification plugin. Override control plugin. * save 3 lines :) * New feature show status. (joomla#47) show status in com_template view templates * link * corrected namespace * Button to Switch (joomla#35) * wip add Switcher * wip style switcher * wip style switch make inline and change on off text * wip start with js * wip js * wip delete buttons and make js more robust * wip save to storage * wip delete old code * wip * wip lint * wip css * set default value for switcher * wip make switcher blue * wip * wip * build * correct names * create new functions * fist test code * use onchange * undo installer.min.js * add forgotten new line at the end of css file * correct align * correct compare.es6 - only deleted the toggle part * correct compare.js - only deleted the toggle part * wip * reduce timeout * wrap in funcitons * wip * add use strict to both js-files(compare and toggle) * add the timeout value of 500 again, because 200 are not enought in my case * use css class 'active' for toggle views * add strict * time out for editor * wip * improvments use newActive and switch * correction * width of switcher-spans * correct align * do not use global * wip * removed timeouts * JTEXT to TEXT * forgotton last line * deleted duplicated comments * css fix align * use unnamed functions in es6 * Sql files for fix database (joomla#50) * sql files for database fix * delete space * Suggestion for displaying Dates in view updates files (joomla#52) Correct Dates and do not use date of file any more * Store Date as UTC and show it in server time zone (joomla#57) * modified and created date are created and stored in UTC * convert dates for displaying in model * spar a loop * normalize timezone in view * use language constants for dateformat * JToolbarHelper to ToolbarHelper * CS * namespace * plural * name * clean * text * fx * sin * files * s * Suggestion for language strings (joomla#60) * language strings * correct typo * delete media folder plg_quickicon * add folder plg_quickicon to build/media_src * delete files in media folder * Move media folder - System (joomla#66) * multi * cs * delete files in media folder for joomla toolbar (joomla#67) * Fix button switchers style. (joomla#70) * button * CS * changed uitab.addTab for updated files * Bring back core.js changes. (joomla#69) * core.js * const * fix * form * core * hound * CS * scopr * grid * alpha * cs * lang * only override file * lang * override lang installer * Cs * sub * Update list of core extensions (joomla#71) * Language changes (joomla#76) * update * Update en-GB.com_templates.ini * override JLIB_HTML_PUBLISH_ITEM this is the hover text on the publish icon in the list of files * Change icon (joomla#74) change the icon to use an outline for more consistency * lang * not core (joomla#75) * not core * Update en-GB.plg_installer_override.ini * namespace * cs * Updated files (joomla#82) * Update default_updated_files.php * Update en-GB.com_templates.ini * Update en-GB.com_templates.ini (joomla#81) * Update en-GB.plg_quickicon_overridecheck.ini (joomla#80) * Update en-GB.plg_quickicon_overridecheck.ini (joomla#79) * remove space (joomla#78) * Update en-GB.plg_quickicon_overridecheck.ini * Update en-GB.plg_quickicon_overridecheck.sys.ini * remove hardcoded id * null get function * state * clean * More changes "core" to "original" (joomla#85) * cs * update * plural

* This is a combination of 8 commits. This is the 1st commit message: > First WIP version of supporting nested subforms. This is the commit message #2: > Fix nested subforms not getting correct name attribute on input fields. This is the commit message #3: > Fix subform rows having invalid index, fix small typo. This is the commit message #4: > Replace the unique subform id via random bytes by just an increasing integer in the fields type rendering process. This is the commit message #5: > Implement feedback from PR at Joomla; > - Use a <template> HTML element for the template of the subform rows, > not a url encoded string inside of a <script> element. > - Fix code style errors reported by phpcs. > - Make the fixing of the unique attributes (name, id, etc) of input elements > of nested subform rows more errorprone, using the same method as the main > subform row. > - Manually add a minified version of the javascript file. This is the commit message #6: > Fix failing javascript tests due to changed structure of subform repeatable template container. This is the commit message #7: > Change subform repeatable javascript test to correctly check on > 0-indexed rows, previously they have been 1-indexed. This is the commit message #8: > Fix a problem where multi-level subforms on the same level doesnt trigger their template correctly. > Additionally added a note why the fixScripts() method is broken and how it could get better. * Commit code styling errors and add an aria label for the outermost 'add' button. * Fix double group-add button on repeatable subform type.

Quickicons split modules

* Add target _blank * Add noopener noreferrer * Add noopener noreferrer * add rel=\"noopener noreferrer\" to plg_twofactorauth_totp.ini (#3) Because discussing about it takes more time than fixing it. ;-) Co-authored-by: Hans Kuijpers <info@hkweb.nl>

…esumable-mod-1 [CMS PR 36708] Revert use DateInterval

…t of type int (joomla#36775) Fixes `Deprecated: preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated in libraries/src/Document/HtmlDocument.php on line 595`

PHP Deprecated: str_replace(): Passing null to parameter #3 ($subject)

Fix deprecation warning with PHP 8.1+ If a replacement string is used, but no 'quicktask' is defined `$params->get('menu-quicktask')` will return `null` which is deprecated in PHP 8.1+. Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in administrator/components/com_menus/src/Helper/MenusHelper.php on line 894

zjw added 3 commits November 19, 2015 10:23

Eliminate duplicated sql statements

1702d42

These updates are already in: administrator/components/com_admin/sql/updates/mysql/3.5.0-2015-10-26.sql

Don't attempt to process blank lines & comments

bf0323e

Eliminate schema differences between updating and a fresh install

1b3c708

zjw mentioned this pull request Nov 19, 2015

Fixed failure on updating database not supporting UTF8MB4 joomla/joomla-cms#8472

Closed

roland-d added a commit that referenced this pull request Nov 19, 2015

Merge pull request #3 from zjw/pr4872test

d800cf8

Suggested changes to your joomla-cms PR 4872

roland-d merged commit d800cf8 into roland-d:utf8mb4 Nov 19, 2015

roland-d pushed a commit that referenced this pull request Dec 14, 2015

Merge pull request #3 from phproberto/rdeutz-8346

6d8f1b7

Fix typos

roland-d pushed a commit that referenced this pull request Feb 17, 2016

Merge pull request #3 from joomla/staging

6f62732

update from upstream

roland-d pushed a commit that referenced this pull request Apr 13, 2016

Merge pull request #3 from wojsmol/patch-7

d08004b

fix for joomla#7359

roland-d pushed a commit that referenced this pull request Apr 13, 2016

Merge pull request #3 from brianteeman/patch-2

bdee865

remove CCOM and replace with COM

roland-d pushed a commit that referenced this pull request Aug 16, 2019

Merge pull request #3 from chmst/quickicons-split-modules

1ce52b3

Quickicons split modules

roland-d pushed a commit that referenced this pull request Jan 29, 2022

Merge pull request #3 from richard67/4.1-dev-nikosdion-feature-task-r…

9962baf

…esumable-mod-1 [CMS PR 36708] Revert use DateInterval

roland-d pushed a commit that referenced this pull request May 27, 2022

php 8.1 (joomla#37903)

14a5f3e

PHP Deprecated: str_replace(): Passing null to parameter #3 ($subject)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Suggested changes to your joomla-cms PR 4872 #3

Suggested changes to your joomla-cms PR 4872 #3

zjw commented Nov 19, 2015

zjw commented Nov 19, 2015

Suggested changes to your joomla-cms PR 4872 #3

Suggested changes to your joomla-cms PR 4872 #3

Conversation

zjw commented Nov 19, 2015

zjw commented Nov 19, 2015