Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fieldgroups list in fields batch modal #13538

Merged
merged 1 commit into from
Jan 10, 2017

Conversation

Bakual
Copy link
Contributor

@Bakual Bakual commented Jan 10, 2017

Pull Request for Issue #13533.

Summary of Changes

The context for the group list was only using the component part instead of the full context.
This fixes that.

Testing Instructions

Check in the fields manager that the batch modal shows all existing fields groups for the active context (eg articles fieldsgroups)

Documentation Changes Required

None

@laoneo
Copy link
Member

laoneo commented Jan 10, 2017

I have tested this item ✅ successfully on 56eb9b1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13538.

@ghost
Copy link

ghost commented Jan 10, 2017

I have tested this item ✅ successfully on 56eb9b1

Works great :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13538.

@jeckodevelopment
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13538.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 10, 2017
@jeckodevelopment jeckodevelopment added this to the Joomla 3.7.0 milestone Jan 10, 2017
@rdeutz rdeutz merged commit 418e72c into joomla:staging Jan 10, 2017
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Jan 10, 2017
@Bakual Bakual deleted the FixFieldsBatch branch January 10, 2017 19:46
roland-d added a commit to roland-d/joomla-cms that referenced this pull request Jan 13, 2017
…sets-option

* 'staging' of github.com:roland-d/joomla-cms: (136 commits)
  Clean up old code in cache.php file (joomla#12183)
  Fixing search for MySQL (joomla#13571)
  Unnecessary double quotes in  /libraries/joomla (joomla#13372)
  Some improvements in tests #3: (joomla#13402)
  It's 2017. Happy New Year
  Fixing a typo in gallery plugin language files
  Add stripslashes to mssql result columns. (joomla#13534)
  remove unneeded space from btn-group/radio/checkboxes (joomla#12003)
  typo (joomla#13563)
  Remove default value from the field params to inherit from plugin
  Remove multiple parameter from user field
  Fix name of component helper in fieldshelper (joomla#13539)
  remove duplicated code (joomla#13550)
  Fix invalid string that causes the ini file not to load (joomla#13544)
  Catch "expects parameter 2 to be string" error
  Take complete context for group lookup (joomla#13538)
  [Mssql] Fix syntax error when installing a language in backend (joomla#13512)
  Normalize #__categories table across 3 db systems and add default values (joomla#13514)
  Normalize #__ucm_content table across 3 db systems and add default values (joomla#13513)
  Update config.xml (joomla#13503)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants