Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize #__categories table across 3 db systems and add default values #13514

Merged
merged 2 commits into from
Jan 10, 2017

Conversation

andrepereiradasilva
Copy link
Contributor

@andrepereiradasilva andrepereiradasilva commented Jan 8, 2017

Pull Request for Issue #13506 and probably other issues relating ucm_content table in more strict db systems (which in joomla 4.0 mysql will be also).

Summary of Changes

Normalize the #__categories table across db systems.
Only tested in mysql.
@waader please check mssql
@alikon please also check postgresql and mssql.

Testing Instructions

  1. SQL code review
  2. Test update: Apply patch, manually run the sql query for your Db system, confirm db table, confirm all fine
  3. Test install: apply patch, delete configuration.php do a normal install, confirm db table, confirm all fine

Documentation Changes Required

None.

@waader
Copy link
Contributor

waader commented Jan 8, 2017

I have tested this item ✅ successfully on 4bc2afa

Works with mssql and postgres.

Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13514.

@alikon
Copy link
Contributor

alikon commented Jan 9, 2017

I have tested this item ✅ successfully on 4bc2afa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13514.

@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Jan 9, 2017
@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label Jan 9, 2017
@rdeutz rdeutz merged commit 5c7681c into joomla:staging Jan 10, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 10, 2017
@andrepereiradasilva andrepereiradasilva deleted the issue-13506 branch January 10, 2017 14:16
roland-d added a commit to roland-d/joomla-cms that referenced this pull request Jan 13, 2017
…sets-option

* 'staging' of github.com:roland-d/joomla-cms: (136 commits)
  Clean up old code in cache.php file (joomla#12183)
  Fixing search for MySQL (joomla#13571)
  Unnecessary double quotes in  /libraries/joomla (joomla#13372)
  Some improvements in tests #3: (joomla#13402)
  It's 2017. Happy New Year
  Fixing a typo in gallery plugin language files
  Add stripslashes to mssql result columns. (joomla#13534)
  remove unneeded space from btn-group/radio/checkboxes (joomla#12003)
  typo (joomla#13563)
  Remove default value from the field params to inherit from plugin
  Remove multiple parameter from user field
  Fix name of component helper in fieldshelper (joomla#13539)
  remove duplicated code (joomla#13550)
  Fix invalid string that causes the ini file not to load (joomla#13544)
  Catch "expects parameter 2 to be string" error
  Take complete context for group lookup (joomla#13538)
  [Mssql] Fix syntax error when installing a language in backend (joomla#13512)
  Normalize #__categories table across 3 db systems and add default values (joomla#13514)
  Normalize #__ucm_content table across 3 db systems and add default values (joomla#13513)
  Update config.xml (joomla#13503)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants