This repository has been archived by the owner on Jun 26, 2024. It is now read-only.
ci: cleanup security checks #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This contains two improvements: - I misconfigured our periodic security checks back in 39908ed, and it wasn't caught in review. Turns out it was rather unnecessary with the checks we have in merge-to-master and merge-to-release-branch. The neutral checks we're seeing are caused by something else; I'll need to investigate to figure out what's going on. - Rather than waiting within the job itself, we can have the jobs for security checks get triggered when the push to quay is done in both the merge-to-master and merge-to-release-branch is done. It should save a few seconds during checks, and it means we won't have a runner waiting doing nothing. Signed-off-by: Andy Sadler <ansadler@redhat.com>
sadlerap
added
the
release/v1.4.x
github-actions
bot
added
the
acceptance-tests-skipped
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1492 +/- ##
=======================================
Coverage 58.16% 58.16%
=======================================
Files 35 35
Lines 3014 3014
=======================================
Hits 1753 1753
Misses 1093 1093
Partials 168 168 Continue to review full report in Codecov by Sentry.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baijum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit 1bc1c94
into
redhat-developer:master
19 checks passed
service-binding-operator-bot
pushed a commit
to service-binding-operator-bot/service-binding-operator
that referenced
this pull request
Sep 14, 2023
This contains two improvements: - I misconfigured our periodic security checks back in 39908ed, and it wasn't caught in review. Turns out it was rather unnecessary with the checks we have in merge-to-master and merge-to-release-branch. The neutral checks we're seeing are caused by something else; I'll need to investigate to figure out what's going on. - Rather than waiting within the job itself, we can have the jobs for security checks get triggered when the push to quay is done in both the merge-to-master and merge-to-release-branch is done. It should save a few seconds during checks, and it means we won't have a runner waiting doing nothing. Signed-off-by: Andy Sadler <ansadler@redhat.com>
openshift-merge-robot
pushed a commit
that referenced
this pull request
Sep 14, 2023
This contains two improvements: - I misconfigured our periodic security checks back in 39908ed, and it wasn't caught in review. Turns out it was rather unnecessary with the checks we have in merge-to-master and merge-to-release-branch. The neutral checks we're seeing are caused by something else; I'll need to investigate to figure out what's going on. - Rather than waiting within the job itself, we can have the jobs for security checks get triggered when the push to quay is done in both the merge-to-master and merge-to-release-branch is done. It should save a few seconds during checks, and it means we won't have a runner waiting doing nothing. Signed-off-by: Andy Sadler <ansadler@redhat.com> Co-authored-by: Andy Sadler <ansadler@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This contains two improvements:
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
included if any changes are user facing
included if any functionality added or changed. For bugfixes please include tests that can catch regressions
@external-feedbacktag.