Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

service-binding-operator-bot
Copy link
Collaborator

Changes

This contains two improvements:

  • I misconfigured our periodic security checks back in 39908ed, and it wasn't caught in review. Turns out it was rather unnecessary with the checks we have in merge-to-master and merge-to-release-branch. The neutral checks we're seeing are caused by something else; I'll need to investigate to figure out what's going on.
  • Rather than waiting within the job itself, we can have the jobs for security checks get triggered when the push to quay is done in both the merge-to-master and merge-to-release-branch is done. It should save a few seconds during checks, and it means we won't have a runner waiting doing nothing.

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

This contains two improvements:
- I misconfigured our periodic security checks back in 39908ed, and it wasn't caught in review.
  Turns out it was rather unnecessary with the checks we have in merge-to-master and
  merge-to-release-branch.  The neutral checks we're seeing are caused by something else; I'll need
  to investigate to figure out what's going on.
- Rather than waiting within the job itself, we can have the jobs for security checks get triggered
  when the push to quay is done in both the merge-to-master and merge-to-release-branch is done.  It
  should save a few seconds during checks, and it means we won't have a runner waiting doing nothing.

Signed-off-by: Andy Sadler <ansadler@redhat.com>
@service-binding-operator-bot service-binding-operator-bot added acceptance-tests-skipped Marks PR that does not need to run the acceptance tests approved cherry-pick kind/bug Something isn't working lgtm release/v1.4.x Used to mark PRs to be cherry-picked in release-v1.4.x branch labels Sep 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #1497 (b50f805) into release-v1.4.x (f01d55b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release-v1.4.x    #1497   +/-   ##
===============================================
  Coverage           58.16%   58.16%           
===============================================
  Files                  35       35           
  Lines                3014     3014           
===============================================
  Hits                 1753     1753           
  Misses               1093     1093           
  Partials              168      168           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f01d55b...b50f805. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit 2f22bb6 into redhat-developer:release-v1.4.x Sep 14, 2023
20 checks passed
@service-binding-operator-bot service-binding-operator-bot deleted the cherry-pick_release-v1.4.x_1bc1c94d_d0aae8c9-2597-4372-8c45-e8cbb4681108 branch September 14, 2023 10:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
acceptance-tests-skipped Marks PR that does not need to run the acceptance tests approved cherry-pick kind/bug Something isn't working lgtm release/v1.4.x Used to mark PRs to be cherry-picked in release-v1.4.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants