test: retry app creation on failure (#1488)

This was causing test failures in CI. Signed-off-by: Andy Sadler <ansadler@redhat.com>
redhat-developer · Aug 25, 2023 · e66264b · e66264b
1 parent 39908ed
commit e66264b
Showing 1 changed file with 13 additions and 5 deletions.
diff --git a/test/acceptance/features/steps/openshift.py b/test/acceptance/features/steps/openshift.py
@@ -568,15 +568,23 @@ def new_app(self, name, image_name, namespace, bindingRoot=None, asDeploymentCon
                 cmd = cmd + f" -e SERVICE_BINDING_ROOT={bindingRoot}"
             if asDeploymentConfig:
                 cmd = cmd + " --as-deployment-config=true"
-            (output, exit_code) = self.cmd.run(cmd)
+            (output, exit_code) = polling2.poll(lambda: self.cmd.run(cmd),
+                                                step=1, timeout=30,
+                                                check_success=lambda x: x[1] == 0)
         else:
             cmd = f"{ctx.cli} create deployment {name} -n {namespace} --image={image_name}"
             if bindingRoot:
-                (output, exit_code) = self.cmd.run(f"{ctx.cli} apply -f -",
-                                                   self.deployment_template.format(name=name, image_name=image_name,
-                                                                                   namespace=namespace, bindingRoot=bindingRoot))
+                (output, exit_code) = polling2.poll(
+                    lambda: self.cmd.run(f"{ctx.cli} apply -f -",
+                                         self.deployment_template.format(name=name,
+                                                                         image_name=image_name,
+                                                                         namespace=namespace,
+                                                                         bindingRoot=bindingRoot)),
+                    step=1, timeout=30,
+                    check_success=lambda x: x[1] == 0)
             else:
-                (output, exit_code) = self.cmd.run(cmd)
+                (output, exit_code) = polling2.poll(lambda: self.cmd.run(cmd), step=1, timeout=30,
+                                                    check_success=lambda x: x[1] == 0)
         assert exit_code == 0, f"Non-zero exit code ({exit_code}) returned when attempting to create a new app using following command line {cmd}\n: {output}"
 
     def set_label(self, name, label, namespace):