-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stability Update 20220425 #45
Conversation
Codecov Report
@@ Coverage Diff @@
## stable #45 +/- ##
==========================================
+ Coverage 91.58% 91.67% +0.09%
==========================================
Files 9 9
Lines 713 721 +8
Branches 51 53 +2
==========================================
+ Hits 653 661 +8
Misses 36 36
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Need to track lack of documentation of the default '224.0.0.1' multicast group from some RFC-REF???
- Need to track need to refactor hard-coded RFC compliant default too.
- Need to use a default error handler rather than throw errors all over; even if the handler just throws an error. one place in the code is better than many.
🤷🏻 Otherwise looks more stable to me
Note documentation on error codes found here 🏷️ for now. |
### ChangeLog: Changes in file Makefile: ifeq "$(RMDIR)" "" install: init build must_be_root Changes in file setup.cfg: summary = Python Multicast Repo for Send/Recv Stubs. Changes in file setup.py: def readFile(filename):
### ChangeLog: Changes in file setup.py: Unknown Changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor fix needed for project.toml
otherwise stable but increases tech debt.
### ChangeLog: Changes in file pyproject.toml: Unknown Changes
### ChangeLog: Changes in file multicast/__init__.py: Unknown Changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a merge candidate for stable
### ChangeLog: Changes in file .github/tool_shlock_helper.sh: Unknown Changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 More debugging will just lead to unneeded churn in the PR
🤷🏻 keep it moving for now.
Some Fixes, Some documentation.
README.md
#39