Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build system technical debt #46

Open
reactive-firewall opened this issue May 2, 2022 · 4 comments
Open

Build system technical debt #46

reactive-firewall opened this issue May 2, 2022 · 4 comments
Assignees
@reactive-firewall
Labels
Python Lang Changes to Python source code Testing Something can be verified
Projects
Multicast Project
Milestone
Code Style Techni...

Comments

@reactive-firewall
Copy link
Owner

This is technical debt ... it is ugly code. either revert way back and use simple open function or refactor to use new build system and use the untested cutting edge. 🤷🏻

Originally posted by @reactive-firewall in #45 (comment)
@reactive-firewall reactive-firewall added this to To do in Multicast Project via automation May 2, 2022
@reactive-firewall reactive-firewall added enhancement New feature or request Python Lang Changes to Python source code labels May 2, 2022
@reactive-firewall
Copy link
Owner Author

ℹ️ Need to use new build system

@reactive-firewall reactive-firewall mentioned this issue May 3, 2022
Merged
9 tasks
reactive-firewall added a commit that referenced this issue Aug 23, 2024
@reactive-firewall
[PEP-517] move to be PEP-517 compatable and away from setup.py (- WIP #…
f2bece5 
…46 -)

Changes in file Makefile:
 build:
  - `build` target now uses the python module `build` instead of setup.py

Changes in file requirements.txt:
 added `build>=1.2.1`

Changes in file setup.cfg:
 version = 1.4.3

Changes in file setup.py:
 minor refactor for python3 only
reactive-firewall added a commit that referenced this issue Aug 23, 2024
@reactive-firewall
Merge branches 'feature-PEP-517' and 'feature' into feature-all
39089dd 
* feature-PEP-517:
  [UPDATE] Version 1.4.3-RC
  [PEP-517] move to be PEP-517 compatable and away from setup.py (- WIP #46 -)

* feature:
  [TESTS] Fix for #49 by adding new test-unit for regressions (- WIP #49 -)
  [TESTS] added regression check for issue with test-reports in some CI runs (- WIP #49 -)

Changes in file .coveragerc:
 + hardened erronious coverage

Changes in file .github/workflows/Tests.yml:
 + new job: REGRESSION

Changes in file Makefile:
 + W.I.P. to move to new build system, see #46
 + improved stability a little

Changes in file multicast/__init__.py:
 + Version 1.4.3 bump

Changes in file requirements.txt:
 + added `build>=1.2.1` as part of #46

Changes in file setup.cfg:
 + Version 1.4.3 bump

Changes in file setup.py:
 - deprecated old build system

Changes in file tests/check_codecov_regression:
 + added new check to verify test-reports from `make test-pytest`
@reactive-firewall
Copy link
Owner Author

ℹ Documentation Links here: https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html
ℹ see also new docs for build module: https://build.pypa.io/en/stable/

@reactive-firewall
Copy link
Owner Author

🙈 Regression in builds for python 3.7 which is EOL already. will remove from mats and demote build to version 1.1.1 to remediate.

reactive-firewall added a commit that referenced this issue Aug 23, 2024
@reactive-firewall
[REGRESSION] fied regression where python 3.7 could not find the pyth…
88d39f7 
…on `build` package. (- WIP #46 -)

Changes in file requirements.txt:
 build>=1.1.1
reactive-firewall added a commit that referenced this issue Aug 23, 2024
@reactive-firewall
[REGRESSION] fixed regression where python 3.7 could not find the pyt…
a7983e0 
…hon `build` package. (- WIP #46 -)

Changes in file requirements.txt:
	build>=1.1.1

Changes in file setup.cfg:
	build>=1.1.1

### ChangeLog:

Changes in file setup.cfg:
 zip_safe = false
reactive-firewall added a commit that referenced this issue Aug 24, 2024
@reactive-firewall
[REGRESSION] possible fix for coverage in CI (- WIP #50 & #46 -)
1d3d85f 
Changes in file .coveragerc:
 minor changes

Changes in file Makefile:
 minor performance improvements and major stability fixes for #50

Changes in file pyproject.toml:
 possible fix for CI - WIP #46

Changes in file tests/check_codecov:
 fixup for strange cornor case where `multicast* != multicast/*` in coverage - WIP #50

Changes in file tests/check_codecov_regression:
 added coverage.xml as valid fix when present
reactive-firewall added a commit that referenced this issue Aug 27, 2024
@reactive-firewall
[REGRESSION] more fixes for stability and reliability (- WIP #46 & #50 …
dcb56fd 
…-)

### ChangeLog:

Changes in file Makefile:
 test-tox: cleanup

Changes in file tests/check_codecov_regression:
 if [[ (${EXIT_CODE} -eq 0) ]] ; then
@reactive-firewall reactive-firewall self-assigned this Aug 27, 2024
@reactive-firewall
Copy link
Owner Author

build module seems like the way forward for now and has been implemented.
Need more testing to ensure no regression related to this issue, but otherwise resolved.

@reactive-firewall reactive-firewall added Testing Something can be verified and removed enhancement New feature or request labels Aug 27, 2024
reactive-firewall added a commit that referenced this issue Aug 27, 2024
@reactive-firewall
[REGRESSION] Possible fixes for multiple regressions in CI (- WIP $41 &
e2a21a2 
#46 & #49 -)

Changes in file .github/workflows/Tests.yml:
 - use same setup as real test when checking for regressions

Changes in file tests/check_cc_lines:
 - workaround for missing `shlock`

Changes in file tests/check_codecov:
 - workaround for missing `shlock`
reactive-firewall added a commit that referenced this issue Aug 27, 2024
@reactive-firewall
[REGRESSION] adding more diognostic output for regressions in CI (- WIP
ffb46e9 
#46 & #49 -)

Changes in file .github/workflows/Tests.yml:
 - output more on regression testing
reactive-firewall added a commit that referenced this issue Aug 27, 2024
@reactive-firewall
[REGRESSION] Fix for regression in last change (- WIP #46 & #49 -)
28ea471 
Changes in file .github/workflows/Tests.yml:
 FIXED TYPO
reactive-firewall added a commit that referenced this issue Aug 27, 2024
@reactive-firewall
[REGRESSION] debug churn (- WIP #46 & #49 -)
54492c4 
Changes in file .github/workflows/Tests.yml:
 minor weird tweaks
reactive-firewall added a commit that referenced this issue Aug 27, 2024
@reactive-firewall
[REGRESSION] debug churn x2 (- WIP #46 & #49 -)
8c0fa3c 
### ChangeLog:

Changes in file .github/workflows/Tests.yml:
 jobs:
reactive-firewall added a commit that referenced this issue Aug 27, 2024
@reactive-firewall
[TESTING] Possible fix for differing results in CI (- WIP #46 & #49 -)
6e1e6d5 
### ChangeLog:

Changes in file Makefile:
 test-style: cleanup must_have_flake
reactive-firewall added a commit that referenced this issue Aug 28, 2024
@reactive-firewall
[REGRESSION] adding even more diognostic output to regression testing…
0111db4 
… (- WIP #46 & #49 -)

### ChangeLog:

Changes in file tests/check_codecov_regression:
 elif [[ ( -d $(git rev-parse --show-toplevel 2>/dev/null) ) ]] ; then
reactive-firewall added a commit that referenced this issue Aug 28, 2024
@reactive-firewall
[REGRESSION] Possible fix by REVERT DESIGN to remove regression check…
e0ac860 
… as it only yields false positives at the moment (- WIP #46 & #49 -)

### ChangeLog:

Changes in file .github/workflows/Tests.yml:
 jobs:
reactive-firewall added a commit that referenced this issue Aug 28, 2024
@reactive-firewall
[TESTS] Posible fix for multiple minor issues (- WIP #46 & #49 -)
418895b 
Changes in file .codecov.yml:
 removeed `setup.py` from coverage quota

Changes in file .coveragerc:
 removeed `setup.py` from coverage quota

Changes in file .github/labeler.yml:
 added license to github label patterns

Changes in file .github/workflows/Tests.yml:
 just a version update

Changes in file README.md:
 improved spacing a little

REMOVED file tests/check_codecov_regression
reactive-firewall added a commit that referenced this issue Aug 28, 2024
@reactive-firewall
[COVERAGE] Minor improvement to coverage scope to ignore missing skip…
2cec28d 
…s of unskipped tests (- WIP #13 & #46 -)

Changes in file .coveragerc:
  ignore skips
reactive-firewall added a commit that referenced this issue Aug 29, 2024
@reactive-firewall
[COVERAGE] add additional coverage testing for legacy build system (-…
cdd5775 
… WIP #46 & #49 & #50 -)

Changes in file .github/workflows/Tests.yml:
 - added extra tests for legacy build system as part of EOL and coverage support

Changes in file Makefile:
 - minor changes to conform with other changes

Changes in file pyproject.toml:
 update for new build system

Changes in file tests/check_integration_coverage:
 improved performance and stability

Changes in file tests/check_legacy_setup_coverage:
 new test case for legacy build system (setup.py)
reactive-firewall added a commit that referenced this issue Aug 29, 2024
@reactive-firewall
* Hotfix-143-B:
6b8269f 
  [COVERAGE] add additional coverage testing for legacy build system (- WIP #46 & #49 & #50 -)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reactive-firewall reactive-firewall

Labels
Python Lang Changes to Python source code Testing Something can be verified
Projects
Multicast Project
Status: Resolved
Multicast Project
To do
Milestone
Code Style Technical Debt
Development

No branches or pull requests
1 participant
@reactive-firewall