Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation out of date in README.md #39

Open
3 tasks done
reactive-firewall opened this issue Mar 24, 2022 · 2 comments · Fixed by #45
Open
3 tasks done

Documentation out of date in README.md #39

reactive-firewall opened this issue Mar 24, 2022 · 2 comments · Fixed by #45
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@reactive-firewall
Copy link
Owner

reactive-firewall commented Mar 24, 2022

Looks like the integration tests usage and the directions in `README.md`` have diverged.

  • design desision on CLI API
  • refactor if needed
  • Update documentation in README.md
@reactive-firewall reactive-firewall added the documentation Improvements or additions to documentation label Mar 24, 2022
@reactive-firewall reactive-firewall moved this from To do to Regressions in Multicast Project Mar 25, 2022
reactive-firewall added a commit that referenced this issue Apr 11, 2022
@reactive-firewall
Copy link
Owner Author

reactive-firewall commented Apr 25, 2022

The CLI is actually not the best way to use this kind of library so it should not be considered the full implementation. For testing though it is quite convenient.

CLI should work like so:

multicast (SAY|RECV|HEAR) [-h|--help] [--use-std] [--daemon] [--port PORT] [--iface IFACE] [--pipe|-m MESSAGE|--message MESSAGE] [--group BIND_GROUP] [--groups [JOIN_MCAST_GROUPS ...]]

the commands are SAY, RECV, and HEAR for the CLI and are analogus to send listen/accept and echo functions of a 1-to-1 connection.

SAY

The SAY command is used to send data messages via multicast diagrams.

  • Note: the --daemon flag has no effect on the SAY command.

RECV

The RECV command is used to receive multicast diagrams by listening or "joining" a multicast group.

  • if the --use-std flag is set the output is printed to the standard-output
  • this command is purely for testing or interfacing with external components and not intended as a first-class API
  • Note: If the --daemon flag is used the process will loop after reporting each diagram until canceled, it has no effect on the RECV command.

HEAR

The HEAR command is used to send data acknowledged messages via "HEAR" messages echoing select received multicast diagrams.

  • while mostly a testing function it is possible to use HEAR as a proxy for other send/recv instances by using the --daemon flag
  • note this will use the same port for sends and receives and can lead to data loss if less than two groups are used.
  • If more than one group is used via the --groups flag then all but the bind group (via --group) will be echoed to the bind group.

@reactive-firewall reactive-firewall self-assigned this Apr 25, 2022
@reactive-firewall reactive-firewall moved this from Regressions to In progress in Multicast Project Apr 25, 2022
@reactive-firewall
Copy link
Owner Author

ℹ️ see #20 for exit-codes.

@reactive-firewall reactive-firewall linked a pull request Apr 25, 2022 that will close this issue
9 tasks
@reactive-firewall reactive-firewall removed a link to a pull request Apr 25, 2022
9 tasks
@reactive-firewall reactive-firewall moved this from In progress to To do in Multicast Project Apr 25, 2022
@reactive-firewall reactive-firewall linked a pull request May 2, 2022 that will close this issue
9 tasks
@reactive-firewall reactive-firewall moved this from To do to Regressions in Multicast Project May 4, 2022
reactive-firewall added a commit that referenced this issue Aug 28, 2024
### ChangeLog:

Changes in file README.md:
 # ... probably will return with nothing outside a handler function in a loop
reactive-firewall added a commit that referenced this issue Aug 29, 2024
Changes in file README.md:
 - updated CLI usage and python usage code (WIP)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Resolved
Development

Successfully merging a pull request may close this issue.

1 participant