Stability Update 20220425 #45

reactive-firewall · 2022-04-25T08:45:38Z

Some Fixes, Some documentation.

Closes 🤔 are these exit codes random or do they have meaning ❓ #20 (round 1)
Closes Document the standard BISP for default values in globals #25
Closes Patch coverage reports are prohibitively strict when overall is over 90% #36
Contributes to Documentation out of date in README.md #39
Closes Improve Project Management #40
Contributes to bug in GH action runner on linux-latest #41 (partial fix for macos)
Fixes Stability fixes #43
Closes Need "Join" to supplement a 1-to-1 "listen" style API #44
Opens Build system technical debt #46 (Won't fix)

codecov · 2022-04-25T08:45:42Z

Codecov Report

Merging #45 (81e3fd0) into stable (14b3eb5) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           stable      #45      +/-   ##
==========================================
+ Coverage   91.58%   91.67%   +0.09%     
==========================================
  Files           9        9              
  Lines         713      721       +8     
  Branches       51       53       +2     
==========================================
+ Hits          653      661       +8     
  Misses         36       36              
  Partials       24       24

Flag	Coverage Δ
3.7	`90.67% <100.00%> (+0.10%)`	⬆️
3.8	`90.76% <100.00%> (+0.10%)`	⬆️
3.9	`90.76% <100.00%> (+0.10%)`	⬆️
macos-latest	`89.36% <100.00%> (+0.12%)`	⬆️
multicast	`89.20% <100.00%> (+0.12%)`	⬆️
ubuntu-latest	`90.21% <100.00%> (+0.11%)`	⬆️
windows-latest	`87.65% <53.84%> (-1.44%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
multicast/__init__.py	`100.00% <ø> (ø)`
multicast/recv.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b3eb5...81e3fd0. Read the comment docs.

reactive-firewall

Need to track lack of documentation of the default '224.0.0.1' multicast group from some RFC-REF???
Need to track need to refactor hard-coded RFC compliant default too.
Need to use a default error handler rather than throw errors all over; even if the handler just throws an error. one place in the code is better than many.
🤷🏻 Otherwise looks more stable to me

.github/tool_shlock_helper.sh

multicast/recv.py

reactive-firewall · 2022-05-02T20:27:44Z

Note documentation on error codes found here 🏷️ for now.

### ChangeLog: Changes in file Makefile: ifeq "$(RMDIR)" "" install: init build must_be_root Changes in file setup.cfg: summary = Python Multicast Repo for Send/Recv Stubs. Changes in file setup.py: def readFile(filename):

### ChangeLog: Changes in file setup.py: Unknown Changes

setup.py

reactive-firewall

Minor fix needed for project.toml otherwise stable but increases tech debt.

Makefile

README.md

setup.cfg

setup.py

pyproject.toml

### ChangeLog: Changes in file pyproject.toml: Unknown Changes

### ChangeLog: Changes in file multicast/__init__.py: Unknown Changes

reactive-firewall

Looks like a merge candidate for stable

multicast/__init__.py

### ChangeLog: Changes in file .github/tool_shlock_helper.sh: Unknown Changes

reactive-firewall

🤔 More debugging will just lead to unneeded churn in the PR
🤷🏻 keep it moving for now.

.github/tool_shlock_helper.sh

reactive-firewall added 4 commits April 21, 2022 23:15

[STYLE] Removed unused argument option in helper tool

daac1d2

[HOTFIX] Seperate hear-step and join-step into seperate functions (WIP …

c50cfce

…#44)

[HOTFIX] regression fix for early stable release

c48fbad

[STYLE] fix for style regression

85ee541

reactive-firewall removed a link to an issue Apr 25, 2022

Documentation out of date in README.md #39

Open

3 tasks

reactive-firewall marked this pull request as ready for review April 25, 2022 08:56

reactive-firewall added this to the plan milestones (first & second iteration) milestone May 1, 2022

reactive-firewall added this to In progress in Multicast Project via automation May 1, 2022

reactive-firewall added documentation Improvements or additions to documentation Multicast Any main project file changes Linter Any linter tool or setting file enhancements labels May 1, 2022

reactive-firewall self-assigned this May 1, 2022

reactive-firewall commented May 1, 2022

View reviewed changes

reactive-firewall linked an issue May 2, 2022 that may be closed by this pull request

🤔 are these exit codes random or do they have meaning ❓ #20

Open

1 task

reactive-firewall linked an issue May 2, 2022 that may be closed by this pull request

Documentation out of date in README.md #39

Open

3 tasks

reactive-firewall removed a link to an issue May 2, 2022

🤔 are these exit codes random or do they have meaning ❓ #20

Open

1 task

reactive-firewall added 4 commits May 2, 2022 13:52

[FEATURE] added code-QL security check status badge ( closes #38 )

2b8bd6c

[FEATURE] added ./pyproject.toml as is current meta ( WIP #40 )

2b90a1c

[FIX] Work around for deprecated build system status.

e80e644

### ChangeLog: Changes in file Makefile: ifeq "$(RMDIR)" "" install: init build must_be_root Changes in file setup.cfg: summary = Python Multicast Repo for Send/Recv Stubs. Changes in file setup.py: def readFile(filename):

[STYLE] fix style regression.

066aaaa

### ChangeLog: Changes in file setup.py: Unknown Changes

reactive-firewall commented May 2, 2022

View reviewed changes

setup.py Outdated Show resolved Hide resolved

reactive-firewall commented May 2, 2022

View reviewed changes

Makefile Show resolved Hide resolved

Makefile Show resolved Hide resolved

README.md Show resolved Hide resolved

setup.cfg Show resolved Hide resolved

setup.py Show resolved Hide resolved

pyproject.toml Outdated Show resolved Hide resolved

reactive-firewall mentioned this pull request May 2, 2022

Build system technical debt #46

Open

[REGRESSION] removed blank lines in pyproject.toml ( fixes #45 )

e8dd04b

### ChangeLog: Changes in file pyproject.toml: Unknown Changes

reactive-firewall closed this in e8dd04b May 2, 2022

Multicast Project automation moved this from In progress to Resolved May 2, 2022

reactive-firewall reopened this May 2, 2022

Multicast Project automation moved this from Resolved to Regressions May 2, 2022

github-actions bot removed Multicast Any main project file changes Linter Any linter tool or setting file enhancements labels May 2, 2022

reactive-firewall moved this from Regressions to In progress in Multicast Project May 2, 2022

reactive-firewall linked an issue May 2, 2022 that may be closed by this pull request

Document the standard BISP for default values in globals #25

Closed

[DOCUMENTATION] Minor improvement to documentation ( WIP #25 )

883a567

### ChangeLog: Changes in file multicast/__init__.py: Unknown Changes

reactive-firewall commented May 2, 2022

View reviewed changes

multicast/__init__.py Show resolved Hide resolved

reactive-firewall mentioned this pull request May 2, 2022

Stability fixes #43

Merged

[REGRESSION] WIP on shlock work around ( WIP #41 )

81e3fd0

### ChangeLog: Changes in file .github/tool_shlock_helper.sh: Unknown Changes

reactive-firewall removed a link to an issue May 3, 2022

bug in GH action runner on linux-latest #41

Open

1 task

reactive-firewall commented May 3, 2022

View reviewed changes

.github/tool_shlock_helper.sh Show resolved Hide resolved

reactive-firewall merged commit 62721b2 into stable May 4, 2022

Multicast Project automation moved this from In progress to Done May 4, 2022

reactive-firewall moved this from Done to Archive Backlog in Multicast Project May 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stability Update 20220425 #45

Stability Update 20220425 #45

reactive-firewall commented Apr 25, 2022 •

edited

Loading

codecov bot commented Apr 25, 2022 •

edited

Loading

reactive-firewall left a comment

reactive-firewall commented May 2, 2022

reactive-firewall left a comment

reactive-firewall left a comment

reactive-firewall left a comment

Stability Update 20220425 #45

Stability Update 20220425 #45

Conversation

reactive-firewall commented Apr 25, 2022 • edited Loading

codecov bot commented Apr 25, 2022 • edited Loading

Codecov Report

reactive-firewall left a comment

Choose a reason for hiding this comment

reactive-firewall commented May 2, 2022

reactive-firewall left a comment

Choose a reason for hiding this comment

reactive-firewall left a comment

Choose a reason for hiding this comment

reactive-firewall left a comment

Choose a reason for hiding this comment

reactive-firewall commented Apr 25, 2022 •

edited

Loading

codecov bot commented Apr 25, 2022 •

edited

Loading