Taught https-download to trust system certstore. #4963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there no way to backport the test, even by pulling in the same infra that was ported later? |
It's all ones and zeroes :) But this test lived in pulp_file in 3.39, and the potential drag is Large. Didn't seem worthwhile - esp given that CI runs on py3.8 and so this test ends up being skipped. |
|
Fair enough, it does invalidate my statement about testing on the BZ though :( |
dralley
approved these changes
Jan 24, 2024
|
@ggainey Have you run the test locally w/ all preconditions met? |
ggainey
deleted the
patchback/backports/3.39/e2119307497f401de95e463e370787143c524016/pr-4951
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3036.
(cherry picked from commit e211930)