-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTPs Proxies not working. #3036
Comments
This works with Python 3.11. Closing the issue since Pulp is not in the position to update Python for users. |
@dkliban Does this work immediately with Python 3.11 or are other patches required? Because I see Partha's PR which monkeypatches the internal flag that enables this support, but that's not all it does, it does other things too. Will we need to adopt some or all of those other changes in order for this to work? If so then this issue ought to be reopened because we won't get this resolved for free by upgrading the Python runtime. |
This should just work with Python 3.11. There are no code changes in Pulp required. |
Reopening - while python/3.11 and recent aiohttp will (finally) allow this, Pulp still needs to load the system-allowed certstore to be able to trust an HTTPS proxy's CA. |
Version
tfm-pulpcore-python3-pulpcore-3.17.7-1.el7.noarch
tfm-pulpcore-python3-aiohttp-3.8.1-2.el7.x86_64
Describe the bug
There was HTTPS proxy tunneling support added to the aiohttp library for 3.8.1 => aio-libs/aiohttp#5992
However pulpcore does not
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Clean Sync
Actual behavior
SSL error while trying to connect to the proxy.
The text was updated successfully, but these errors were encountered: