Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Taught https-download to trust system certstore. #4963

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Taught https-download to trust system certstore. #4963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/3036.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Taught downloader to trust system-cert-store on HTTPS proxy connections.
2 changes: 2 additions & 0 deletions pulpcore/download/factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,8 @@ def _make_aiohttp_session_from_remote(self):
sslcontext.verify_mode = ssl.CERT_NONE
if sslcontext:
tcp_conn_opts["ssl_context"] = sslcontext
# Trust the system-known CA certs, not just the end-remote CA
sslcontext.load_default_certs()

headers = MultiDict({"User-Agent": DownloaderFactory.user_agent()})
if self._remote.headers is not None:
Expand Down
Loading