Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AggregateAttestationAndProof #80

Merged
merged 3 commits into from
Dec 11, 2019
Merged

Update AggregateAttestationAndProof #80

merged 3 commits into from
Dec 11, 2019

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented Dec 11, 2019 •
edited
Loading

Change list:

  • Better comments (complete sentences)
  • Aligned ordering and field name with latest spec

@terencechain terencechain self-assigned this Dec 11, 2019
@rauljordan rauljordan merged commit 69531c1 into v0.9.2 Dec 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the aggregate1 branch December 11, 2019 17:09
prestonvanloon
prestonvanloon reviewed Dec 12, 2019
View reviewed changes
eth/v1alpha1/attestation.proto
Attestation aggregate = 3;

// The selection proof signed by the aggregator, which is the signature of the slot to aggregate.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the bytes size. Is this 96 bytes signature?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fe50924

rauljordan added a commit that referenced this pull request Jan 7, 2020
@terencechain @mcdee
@rauljordan @prestonvanloon
V0.9.2 (#70)
1ca2fc8 
* Removed custody bits

* Mirror change in master in 0.9.2 (#73)

* mod validator proto

* regen

* sync protos

* Include Validator Indices in Common Validator List Responses (#75)

* Align Duties Response With v0.9.2 (#77)

* standardize spacing (#78)

* Added AggregateAttestationAndProof (#79)

* Update AggregateAttestationAndProof (#80)

* Added AggregateAttestationAndProof

* Better comments

* Update attestation.proto

* Revert 2a889fe

* Rm signing root changes (#90)

* Updated messages

* Generate pb.go

* use signed block in block container

* Propose signed objects

* fix protos

* regen

Co-authored-by: Jim McDonald <Jim@mcdee.net>
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvanloon prestonvanloon prestonvanloon left review comments

Assignees

@terencechain terencechain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terencechain @prestonvanloon @rauljordan